Refactor ResourceRegionHttpMessageConverter #34053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2024 23:16
Extract collection handling into a separate method and use a stream-based all-match check to improve readability and maintainability. Also introduce new test cases to verify functionality and reliability of the supportsRepeatableWrites function.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, but I don't think the code change really improves readability and maintanability (those are really subjective). Also we usually avoid introducing |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract collection handling into a separate method and use a stream-based all-match check to improve readability and maintainability.
Also introduce new test cases to verify functionality and reliability of the supportsRepeatableWrites function.