Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -140,19 +140,15 @@ protected MediaType getDefaultContentType(Object object) {

@Override
protected boolean supportsRepeatableWrites(Object object) {
if (object instanceof ResourceRegion resourceRegion) {
return supportsRepeatableWrites(resourceRegion);
}
else {
@SuppressWarnings("unchecked")
Collection<ResourceRegion> regions = (Collection<ResourceRegion>) object;
for (ResourceRegion region : regions) {
if (!supportsRepeatableWrites(region)) {
return false;
}
}
return true;
}
return (object instanceof ResourceRegion resourceRegion) ?
supportsRepeatableWrites(resourceRegion) :
supportsRepeatableWritesInRegionCollection(object);
}

private boolean supportsRepeatableWritesInRegionCollection(Object object) {
@SuppressWarnings("unchecked")
Collection<ResourceRegion> resourceRegions = (Collection<ResourceRegion>) object;
return resourceRegions.stream().allMatch(this::supportsRepeatableWrites);
}

private boolean supportsRepeatableWrites(ResourceRegion region) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.stream.Stream;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;

import org.springframework.core.ParameterizedTypeReference;
import org.springframework.core.io.ClassPathResource;
Expand Down Expand Up @@ -181,6 +185,26 @@ void partialContentMultipleByteRangesInRandomOrderAndOverlapping() throws Except
assertThat(ranges[15]).isEqualTo("t resource");
}

@Test
void testSingleResourceRegionSupportsRepeatableWrites() {
ResourceRegion region = mock(ResourceRegion.class);
assertThat(converter.supportsRepeatableWrites(region)).isTrue();
}

@ParameterizedTest
@MethodSource("regionCollections")
void testCollectionOfResourceRegionSupportsRepeatableWrites(Object regionCollection, boolean expected) {
assertThat(converter.supportsRepeatableWrites(regionCollection)).isEqualTo(expected);
}

static Stream<Arguments> regionCollections() {
return Stream.of(
Arguments.of(Collections.emptyList(), true),
Arguments.of(Collections.singletonList(mock(ResourceRegion.class)), true),
Arguments.of(List.of(mock(ResourceRegion.class), mock(ResourceRegion.class)), true)
);
}

@Test // SPR-15041
public void applicationOctetStreamDefaultContentType() throws Exception {
MockHttpOutputMessage outputMessage = new MockHttpOutputMessage();
Expand Down
Loading