Skip to content

Fix jitter handling in AbstractRetryInterceptor #35140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Fix jitter handling in AbstractRetryInterceptor #35140

merged 1 commit into from
Jul 1, 2025

Conversation

NeatGuyCoding
Copy link
Contributor

@NeatGuyCoding NeatGuyCoding commented Jul 1, 2025 •
edited by sbrannen
Loading

Overview

Fix potential loss of precision, and test jitter handling with unit tests.

Related Issues

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 1, 2025
@jhoeller jhoeller self-assigned this Jul 1, 2025
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 1, 2025
@jhoeller jhoeller added this to the 7.0.0-M7 milestone Jul 1, 2025
@jhoeller jhoeller mentioned this pull request Jul 1, 2025
Closed
@jhoeller
Copy link
Contributor

jhoeller commented Jul 1, 2025 •
edited
Loading

Good catch! I'll merge this right away in preparation of #35133 where the aop.retry package is about to be moved to org.springframework.resilience.retry in the spring-context module.

@jhoeller jhoeller merged commit 009b880 into spring-projects:main Jul 1, 2025
4 of 5 checks passed
@sbrannen sbrannen added type: task A general task and removed type: enhancement A general enhancement labels Jul 1, 2025
@sbrannen
Copy link
Member

sbrannen commented Jul 1, 2025

Changed to a task since this feature has not yet been released.

@sbrannen sbrannen changed the title Fix potentially loses precision and jitter is not well capped with unit tests Fix jitter handling in AbstractRetryInterceptor Jul 1, 2025
This was referenced Jul 1, 2025
Closed
Closed
@NeatGuyCoding NeatGuyCoding deleted the fix-retry-interceptor branch July 2, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
7.0.0-M7
Development

Successfully merging this pull request may close these issues.
4 participants
@NeatGuyCoding @jhoeller @sbrannen @spring-projects-issues