Support relative topicPattern without requiring full tenant/namespace prefix #1240 #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oneby-wang
force-pushed
the
topicPattern_fullyQualified
branch
2 times, most recently
from
3a2477a to
1f4c3ed
Compare
added 2 commits
September 3, 2025 20:16
…espace prefix spring-projects#1240 Signed-off-by: oneby-wang <[email protected]>
…ests Signed-off-by: oneby-wang <[email protected]>
oneby-wang
force-pushed
the
topicPattern_fullyQualified
branch
from
1f4c3ed to
d937d4b
Compare
oneby-wang
commented
Sep 5, 2025
...-pulsar/src/test/java/org/springframework/pulsar/core/DefaultPulsarConsumerFactoryTests.java
Show resolved
Hide resolved
Collaborator
|
Thank you for the great contribution @oneby-wang (especially the improvement in the tests - much appreciated)! I added a small polish commit HERE and closing this PR in favor of cab35a7 |
Author
|
Thank you for reviewing and polishing the code. I'm very glad to be able to contribute spring-pulsar community. |
Collaborator
You are very welcome. We are also glad to have you contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Support relative topicPattern without requiring full tenant/namespace prefix #1240.
Call getFullyQualifiedNameForTopic(topicsPattern) and re-set topicsPattern in consumerBuilder. See DefaultPulsarConsumerFactory and DefaultReactivePulsarConsumerFactory.