Skip to content

Conversation

ororsatti
Copy link

@ororsatti ororsatti commented Jun 27, 2025

Issue

Fixes #3998

Description

Fixing 2 issues:

  • insert statement with 'default values': insert into <table_name> default values;
  • insert statement with 'default values' and a returning statement: insert into <table_name> default values returning *;

The sqlite parser grammer was incorrect.

Tests

  • tested locally
  • added insert with values test case

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 27, 2025
@dosubot dosubot bot added the 🔧 golang label Jun 27, 2025
@ororsatti
Copy link
Author

I would also suggest taking a look on the new Sqlite parser grammar by Antlr: https://github.com/antlr/grammars-v4/tree/master/sql/sqlite

I can migrate.

@kyleconroy kyleconroy closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files. 🔧 golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEFAULT VALUES doesn't work on sqlite
2 participants