Skip to content

Fix #3998: insert stmt with 'default values' doesn't work in SQLite #4002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix #3998: insert stmt with 'default values' doesn't work in SQLite #4002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c333ea
fix: move default values stmt
ororsatti Jun 27, 2025
6083bfd
test: add default values expr
ororsatti Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/endtoend/testdata/insert_values/sqlite/go/query.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion internal/endtoend/testdata/insert_values/sqlite/query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@
INSERT INTO foo (a, b) VALUES (?, ?);

/* name: InsertMultipleValues :exec */
INSERT INTO foo (a, b) VALUES (?, ?), (?, ?);
INSERT INTO foo (a, b) VALUES (?, ?), (?, ?);

/* name: InsertDefaultValues :exec */
INSERT INTO foo DEFAULT VALUES;
2 changes: 1 addition & 1 deletion internal/endtoend/testdata/insert_values/sqlite/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
CREATE TABLE foo (a text, b integer);
CREATE TABLE foo (a text, b integer default 100);

2 changes: 1 addition & 1 deletion internal/engine/sqlite/parser/SQLiteParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ insert_stmt:
)*
| select_stmt
) upsert_clause? returning_clause?
| DEFAULT_ VALUES_ returning_clause?
)
| DEFAULT_ VALUES_
;

upsert_clause:
Expand Down
2 changes: 1 addition & 1 deletion internal/engine/sqlite/parser/SQLiteParser.interp
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading