Replace hardcoded strings with customizable attributes in multiple components #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding two options: search_button search_placeholder
adding search_placeholder option
documentation update for the shell component options: search_placeholder search_button and for the table component option: search_placeholder
lovasoa
changed the title
|
@amrutadotorg , thank you; it's merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tablecomponent:search_placeholderCustomizes the text displayed in the search input field when empty. Replaces the default Search... placeholder with text that better describes what users should search for.shellcomponent:search_buttonCustomizes the text displayed on the search button. Replaces the default Search label with custom text that may better match your applications terminology or language.
search_placeholderCustomizes the text displayed in the search input field when empty. Replaces the default Search placeholder with text that better describes what users should search for.