Skip to content

Replace volatile counters with std::atomic types#1258

Closed
leekillough wants to merge 2 commits intosstsimulator:develfrom
leekillough:volatile_deprecated
Closed

Replace volatile counters with std::atomic types#1258
leekillough wants to merge 2 commits intosstsimulator:develfrom
leekillough:volatile_deprecated

Conversation

@leekillough
Copy link
Contributor

@leekillough leekillough commented Mar 16, 2025

Replace volatile counters with std::atomic types, except in one case where the assembly code is listed and analyzed and volatile is used for a timing delay. volatile is deprecated.

@leekillough
Replace volatile counters with std::atomic types, except in one case …
de046da 
…where the

assembly code is listed and analyzed and "volatile" is used for a timing delay.
@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 16, 2025
@github-actions
Copy link

github-actions bot commented Mar 16, 2025

CLANG-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Mar 16, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 16, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 17, 2025

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 17, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1875
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1831
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1830
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 823
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 676
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 630
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 398
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 248
  • Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)
  • Branch: volatile_deprecated
  • SHA: de046da
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: fc3830fbe74ce06cebb6b6838c78777a6855707a
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: c340487db57cb277a0cf4037dd8995763307d7ef
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 42e85e1689d473c65fdbcc008ce57fd53fe80865
  • Mode: SUPPORT_REPO

Pull Request Author: leekillough

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 17, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1875
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1831
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1830
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 823
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 676
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 630
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 398
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 248
  • Status: PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 17, 2025

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 17, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

4 similar comments
@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 18, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 18, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 18, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 18, 2025

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@feldergast feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 18, 2025
@github-actions github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025
@github-actions
Copy link

github-actions bot commented Mar 23, 2025

CLANG-FORMAT TEST - PASSED

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 23, 2025
@github-actions
Copy link

github-actions bot commented Mar 23, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 23, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@feldergast feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025
@gvoskuilen
Copy link
Contributor

gvoskuilen commented Mar 25, 2025

@leekillough Do you know if these changes are compatible with PinCRT? This file gets compiled into both SST and a Pintool so there are restrictions on what it can include and the atomic needs to work in a shared memory region between SST & the pintool.

@leekillough
Copy link
Contributor Author

leekillough commented Mar 25, 2025

@leekillough Do you know if these changes are compatible with PinCRT? This file gets compiled into both SST and a Pintool so there are restrictions on what it can include and the atomic needs to work in a shared memory region between SST & the pintool.

No, I don't know anything about PinCRT. I would expect than an atomic would work unless the shared memory gets remapped after the std::atomic is constructed. But if multiple processes/threads/whatever access mapped memory with atomic instructions, it should produce the desired effects that volatile produced.

In reviewing the PinCRT documentation, release notes, etc., C++11 support has been only added recently, and in a 2023 release note, it says that C++11 atomic are not supported.

  Pin on Linux C++ 17 Support

o Pin on Linux now supports large portions of C++ 17 standard with the following known issues:
§ RTTI and exceptions are not supported (as in previous Pin versions)
§ Thread safety and Concurrency support library are not supported
· The above applies also to std::atomic_xxx(std::shared_ptr) utility functions
· Users must continue using Pin Thread API and LOCK primitives for multi threading scenarios and concurrency control

@leekillough leekillough deleted the volatile_deprecated branch March 31, 2025 04:09
@berquist berquist added this to the SST V15.0.0 milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS AT: WIP Mark PR as a Work in Progress (No Autotesting Performed)

Projects

None yet

Milestone

SST V15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@leekillough @sst-autotester @gvoskuilen @berquist @feldergast