Skip to content

Replace volatile counters with std::atomic types #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leekillough wants to merge 2 commits into from
Closed

Replace volatile counters with std::atomic types #1258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de046da
Replace volatile counters with std::atomic types, except in one case …
leekillough Mar 16, 2025
8e23a34
Merge remote-tracking branch 'sstcore/devel' into volatile_deprecated
leekillough Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/sst/core/interprocess/tunneldef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@

#include "sst/core/interprocess/circularBuffer.h"

#include <inttypes.h>
#include <atomic>
#include <cinttypes>
#include <unistd.h>
#include <utility>
#include <vector>

namespace SST::Core::Interprocess {
Expand All @@ -33,10 +35,10 @@ extern uint32_t globalMMAPIPCCount;
/* Internal bookkeeping */
struct InternalSharedData
{
volatile uint32_t expectedChildren;
size_t shmSegSize;
size_t numBuffers;
size_t offsets[0]; // offset[0] points to user region, offset[1]... points to circular buffers
std::atomic_uint32_t expectedChildren;
size_t shmSegSize;
size_t numBuffers;
size_t offsets[0]; // offset[0] points to user region, offset[1]... points to circular buffers
};

/**
Expand Down
Loading