Inline trivial default constructors and destructors#1260
Inline trivial default constructors and destructors#1260feldergast merged 3 commits intosstsimulator:develfrom
Conversation
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - FAILED (on last commit): |
github-actions
bot
added
AT: CMAKE-FORMAT PASS
and removed
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
github-actions
bot
added
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
github-actions
bot
added
AT: CLANG-FORMAT PASS
and removed
AT: CLANG-FORMAT FAIL
labels
|
CLANG-FORMAT TEST - PASSED |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
feldergast
added
the
AT: WIP
github-actions
bot
removed
the
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
github-actions
bot
added
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
feldergast
added
the
AT: WIP
leekillough
force-pushed
the
inline_trivial_ctor_dtor
branch
from
d1122fa to
f73b329
Compare
github-actions
bot
removed
the
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
|
CMAKE-FORMAT TEST - PASSED |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
…tialized
and an empty constructor body, and for destructors with an empty body, move the
definiton from the .cc file to the .h file with a = default definition.
Default constructors and destructors defined with empty bodies in the header
could be replaced with = default which is more specific than {} and could
conceivably be more optimized. To minimize diffs, these {} default constructors
and destructors in headers were left alone. Only if they were newly added or
moved from .cc to .h files, was = default used instead of {}. This makes the
new constructors/destructors potentially inline-able.
leekillough
force-pushed
the
inline_trivial_ctor_dtor
branch
from
f73b329 to
4f4899c
Compare
github-actions
bot
added
AT: WIP
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - GitHub reports Mergeable status = False |
|
This PR is now unmergeable. Please resolve conflicts. |
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - FAILED (on last commit): |
github-actions
bot
removed
AT: CLANG-FORMAT PASS
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
github-actions
bot
added
AT: WIP
|
CLANG-FORMAT TEST - PASSED |
|
CMAKE-FORMAT TEST - PASSED |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore
Using Repos:
Pull Request Author: leekillough |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist
Build InformationTest Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements
Build InformationTest Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ feldergast ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge |
4 participants
For default constructors with all bases and class members default-initialized
()and an empty constructor body, and for destructors with an empty body, move the definition from the.ccfile to the.hfile with a= defaultdefinition.Default constructors and destructors defined with empty bodies in the header could be replaced with
= defaultwhich is more specific than{}and could conceivably be more optimized. To minimize diffs, these{}default constructors and destructors in headers were left alone. Only if they were newly added or moved from.ccto.hfiles, was= defaultused instead of{}.