Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sst/core/baseComponent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@

namespace SST {

BaseComponent::BaseComponent() : SST::Core::Serialization::serializable_base() {}

BaseComponent::BaseComponent(ComponentId_t id) :
SST::Core::Serialization::serializable_base(),
my_info(Simulation_impl::getSimulation()->getComponentInfo(id)),
Expand Down
3 changes: 1 addition & 2 deletions src/sst/core/baseComponent.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ class BaseComponent : public SST::Core::Serialization::serializable_base
BaseComponent*, Statistics::StatisticProcessingEngine*, const std::string& /*type*/,
const std::string& /*name*/, const std::string& /*subId*/, Params&)>;

// For serialization only
BaseComponent();
BaseComponent() = default; // For serialization only

public:
BaseComponent(ComponentId_t id);
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/checkpointAction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ CheckpointAction::CheckpointAction(Config* cfg, RankInfo this_rank, Simulation_i
}
}

CheckpointAction::~CheckpointAction() {}

void
CheckpointAction::insertIntoTimeVortex(Simulation_impl* sim)
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/checkpointAction.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class CheckpointAction : public Action
Create a new checkpoint object for the simulation core to initiate checkpoints
*/
CheckpointAction(Config* cfg, RankInfo this_rank, Simulation_impl* sim, TimeConverter* period);
~CheckpointAction();
~CheckpointAction() = default;

/**
Indicates CheckpointAction should be inserted into the
Expand Down
5 changes: 0 additions & 5 deletions src/sst/core/component.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ Component::Component(ComponentId_t id) : BaseComponent(id)
// currentlyLoadingSubComponent = my_info;
}

Component::~Component() {}

void
Component::registerAsPrimaryComponent()
{
Expand Down Expand Up @@ -59,7 +57,4 @@ Component::serialize_order(SST::Core::Serialization::serializer& ser)
BaseComponent::serialize_order(ser);
}

// For serialization only
Component::Component() : BaseComponent() {}

} // namespace SST
6 changes: 2 additions & 4 deletions src/sst/core/component.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class Component : public BaseComponent
@param id Unique component ID
*/
Component(ComponentId_t id);
virtual ~Component();
virtual ~Component() override = default;

/** Register as a primary component, which allows the component to
specify when it is and is not OK to end simulation. The
Expand Down Expand Up @@ -97,9 +97,7 @@ class Component : public BaseComponent

protected:
friend class SubComponent;

// For Serialization only
Component();
Component() = default; // For Serialization only
};

} // namespace SST
Expand Down
3 changes: 0 additions & 3 deletions src/sst/core/componentExtension.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,4 @@ ComponentExtension::serialize_order(SST::Core::Serialization::serializer& ser)
BaseComponent::serialize_order(ser);
}

// For serialization only
ComponentExtension::ComponentExtension() : BaseComponent() {}

} // namespace SST
5 changes: 2 additions & 3 deletions src/sst/core/componentExtension.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,10 @@ class ComponentExtension : public BaseComponent
public:
ComponentExtension(ComponentId_t id);

virtual ~ComponentExtension() {};
virtual ~ComponentExtension() override = default;

private:
// For serialization only
ComponentExtension();
ComponentExtension() = default; // For serialization only

ImplementSerializable(SST::ComponentExtension)
void serialize_order(SST::Core::Serialization::serializer& ser) override;
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/event.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ namespace SST {
std::atomic<uint64_t> SST::Event::id_counter(0);
const SST::Event::id_type SST::Event::NO_ID = std::make_pair(0, -1);

Event::~Event() {}

void
Event::execute()
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/event.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class Event : public Activity
last_comp = "";
#endif
}
virtual ~Event();
~Event() override = default;

/** Clones the event in for the case of a broadcast */
virtual Event* clone();
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/heartbeat.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ SimulatorHeartbeat::SimulatorHeartbeat(
if ( (0 == this_rank) ) { lastTime = sst_get_cpu_time(); }
}

SimulatorHeartbeat::~SimulatorHeartbeat() {}

void
SimulatorHeartbeat::schedule()
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/heartbeat.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class SimulatorHeartbeat : public Action
Create a new heartbeat object for the simulation core to show progress
*/
SimulatorHeartbeat(Config* cfg, int this_rank, Simulation_impl* sim, TimeConverter* period);
~SimulatorHeartbeat();
~SimulatorHeartbeat() = default;

// Used to re-schedule the new heartbeat event during restart
void schedule();
Expand Down
1 change: 0 additions & 1 deletion src/sst/core/initQueue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace SST {

InitQueue::InitQueue() : ActivityQueue() {}
InitQueue::~InitQueue()
{
// Need to delete any events left in the queue
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/initQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace SST {
class InitQueue : public ActivityQueue
{
public:
InitQueue();
InitQueue() = default;
~InitQueue();

bool empty() override;
Expand Down
5 changes: 0 additions & 5 deletions src/sst/core/interactiveConsole.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ namespace SST {
SST_ELI_DEFINE_INFO_EXTERN(SST::InteractiveConsole)
SST_ELI_DEFINE_CTOR_EXTERN(SST::InteractiveConsole)


InteractiveConsole::InteractiveConsole() {}

InteractiveConsole::~InteractiveConsole() {}

UnitAlgebra
InteractiveConsole::getCoreTimeBase() const
{
Expand Down
4 changes: 2 additions & 2 deletions src/sst/core/interactiveConsole.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ class InteractiveConsole
/**
Create a new checkpoint object for the simulation core to initiate checkpoints
*/
InteractiveConsole();
virtual ~InteractiveConsole();
InteractiveConsole() = default;
virtual ~InteractiveConsole() = default;

/** Called by TimeVortex to trigger checkpoint on simulation clock interval - not used in parallel simulation */
virtual void execute(const std::string& msg) = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/sst/core/model/python/pymodel_comp.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ struct PyComponent : ComponentHolder
uint16_t subCompId;

PyComponent(ComponentPy_t* pobj, SST::ComponentId_t id) : ComponentHolder(pobj, id), subCompId(0) {}
~PyComponent() {}
~PyComponent() override = default;
};

struct PySubComponent : ComponentHolder
{
PySubComponent(ComponentPy_t* pobj, SST::ComponentId_t id) : ComponentHolder(pobj, id) {}
~PySubComponent() {}
~PySubComponent() override = default;
int getSlot();
};

Expand Down
1 change: 0 additions & 1 deletion src/sst/core/pollingLinkQueue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

namespace SST {

PollingLinkQueue::PollingLinkQueue() : ActivityQueue() {}
PollingLinkQueue::~PollingLinkQueue()
{
// Need to delete any events left in the queue
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/pollingLinkQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace SST {
class PollingLinkQueue : public ActivityQueue
{
public:
PollingLinkQueue();
PollingLinkQueue() = default;
~PollingLinkQueue();

bool empty() override;
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/portModule.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ namespace SST {
SST_ELI_DEFINE_INFO_EXTERN(PortModule)
SST_ELI_DEFINE_CTOR_EXTERN(PortModule)

PortModule::PortModule() {}

uintptr_t
PortModule::registerLinkAttachTool(const AttachPointMetaData& UNUSED(mdata))
{
Expand Down
3 changes: 1 addition & 2 deletions src/sst/core/portModule.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ class PortModule :
// ELI::ProvidesStats, // Will add stats in the future
ELI::ProvidesAttributes)


PortModule();
PortModule() = default;
virtual ~PortModule() {};

/******* Functions inherited from Link::AttachPoint *******/
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/realtime.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ SST_ELI_DEFINE_INFO_EXTERN(RealTimeAction)
SST_ELI_DEFINE_CTOR_EXTERN(RealTimeAction)


RealTimeAction::RealTimeAction() {}

UnitAlgebra
RealTimeAction::getCoreTimeBase() const
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/realtimeAction.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ class RealTimeAction
SST_ELI_DECLARE_DEFAULT_INFO_EXTERN()
SST_ELI_DECLARE_DEFAULT_CTOR_EXTERN()

RealTimeAction() = default;

RealTimeAction();
virtual ~RealTimeAction() = default;

/* Optional function called just before run loop starts. Passes in
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/sstinfo.cc
Original file line number Diff line number Diff line change
Expand Up @@ -753,8 +753,6 @@ SSTInfoConfig::SSTInfoConfig(bool suppress_print) : ConfigShared(suppress_print,
addPositionalCallback(std::bind(&SSTInfoConfig::setPositionalArg, this, _1, _2));
}

SSTInfoConfig::~SSTInfoConfig() {}

std::string
SSTInfoConfig::getUsagePrelude()
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/sstinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class SSTInfoConfig : public ConfigShared
using FilterMap_t = std::multimap<std::string, std::string>;
/** Create a new SSTInfo configuration and parse the Command Line. */
SSTInfoConfig(bool suppress_print);
~SSTInfoConfig();
~SSTInfoConfig() override = default;

/** Return the list of elements to be processed. */
std::set<std::string> getElementsToProcessArray()
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/statapi/statoutput.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ StatisticOutput::StatisticOutput(Params& outputParameters)
SST_ELI_DEFINE_CTOR_EXTERN(StatisticOutput)
SST_ELI_DEFINE_INFO_EXTERN(StatisticOutput)

StatisticOutput::~StatisticOutput() {}

void
StatisticOutput::serialize_order(SST::Core::Serialization::serializer& ser)
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/statapi/statoutput.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class StatisticOutput : public SST::Core::Serialization::serializable
using FieldNameMap_t = std::unordered_map<std::string, fieldHandle_t>;

public:
~StatisticOutput();
~StatisticOutput() = default;

/** Return the Statistic Output name */
std::string& getStatisticOutputName() { return m_statOutputName; }
Expand Down
3 changes: 0 additions & 3 deletions src/sst/core/subcomponent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,4 @@ SubComponent::serialize_order(SST::Core::Serialization::serializer& ser)
BaseComponent::serialize_order(ser);
}

// For serialization only
SubComponent::SubComponent() : BaseComponent() {}

} // namespace SST
3 changes: 1 addition & 2 deletions src/sst/core/subcomponent.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ class SubComponent : public BaseComponent
virtual void finish() override {}

protected:
// For serialization only
SubComponent();
SubComponent() = default; // For serialization only
void serialize_order(SST::Core::Serialization::serializer& ser) override;

friend class Component;
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/sync/syncManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,6 @@ SyncManager::SyncManager()
sim_ = Simulation_impl::getSimulation();
}

SyncManager::~SyncManager() {}

/** Register a Link which this Sync Object is responsible for */
ActivityQueue*
SyncManager::registerLink(const RankInfo& to_rank, const RankInfo& from_rank, const std::string& name, Link* link)
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/sync/syncManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class SyncManager : public Action
const RankInfo& rank, const RankInfo& num_ranks, SimTime_t min_part,
const std::vector<SimTime_t>& interThreadLatencies, RealTimeManager* real_time);
SyncManager(); // For serialization only
virtual ~SyncManager();
virtual ~SyncManager() = default;

/** Register a Link which this Sync Object is responsible for */
ActivityQueue*
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/sync/syncQueue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ using namespace Core::Serialization;

RankSyncQueue::RankSyncQueue(RankInfo to_rank) : SyncQueue(to_rank), buffer(nullptr), buf_size(0) {}

RankSyncQueue::~RankSyncQueue() {}

bool
RankSyncQueue::empty()
{
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/sync/syncQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class RankSyncQueue : public SyncQueue
};

RankSyncQueue(RankInfo to_rank);
~RankSyncQueue();
~RankSyncQueue() = default;

bool empty() override;
int size() override;
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/testElements/coreTest_Checkpoint.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class coreTestCheckpoint : public SST::Component
)

coreTestCheckpoint(ComponentId_t id, SST::Params& params);
virtual ~coreTestCheckpoint();
~coreTestCheckpoint();

void init(unsigned phase) override;

Expand Down
5 changes: 0 additions & 5 deletions src/sst/core/testElements/coreTest_Component.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,6 @@ coreTestComponent::~coreTestComponent()
delete rng;
}

coreTestComponent::coreTestComponent() : coreTestComponentBase2()
{
// for serialization only
}

// incoming events are scanned and deleted
void
coreTestComponent::handleEvent(Event* ev)
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/testElements/coreTest_Component.h
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class coreTestComponent : public coreTestComponentBase2

void serialize_order(SST::Core::Serialization::serializer& ser) override;
ImplementSerializable(SST::CoreTestComponent::coreTestComponent)
coreTestComponent(); // for serialization only
coreTestComponent() = default; // for serialization only

private:
coreTestComponent(const coreTestComponent&) = delete; // do not implement
Expand Down
2 changes: 0 additions & 2 deletions src/sst/core/testElements/coreTest_Links.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ coreTestLinks::coreTestLinks(ComponentId_t id, Params& params) : Component(id),
registerClock("100 MHz", new Clock::Handler<coreTestLinks>(this, &coreTestLinks::clockTic));
}

coreTestLinks::~coreTestLinks() {}

// incoming events are scanned and deleted
void
coreTestLinks::handleEvent(Event* ev, std::string from)
Expand Down
2 changes: 1 addition & 1 deletion src/sst/core/testElements/coreTest_Links.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class coreTestLinks : public SST::Component
)

coreTestLinks(SST::ComponentId_t id, SST::Params& params);
~coreTestLinks();
~coreTestLinks() = default;

void setup() {}
void finish() {}
Expand Down
4 changes: 0 additions & 4 deletions src/sst/core/testElements/coreTest_Module.cc
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,6 @@ void
coreTestModuleLoader::finish()
{}

coreTestModuleLoader::coreTestModuleLoader() : Component()
{ /* For serialization ONLY*/
}

bool coreTestModuleLoader::tick(SST::Cycle_t)
{
uint32_t next = rng_module->getNext();
Expand Down
Loading
Loading