Skip to content

Add override for virtual functions which are overriden#1261

Merged
feldergast merged 2 commits intosstsimulator:develfrom
leekillough:override
Apr 19, 2025
Merged

Add override for virtual functions which are overriden#1261
feldergast merged 2 commits intosstsimulator:develfrom
leekillough:override

Conversation

@leekillough
Copy link
Contributor

@leekillough leekillough commented Mar 16, 2025

Add override for virtual functions which are overriden (as warned by -Wsuggest-override).

virtual could be removed wherever override was used. override implies virtual, but it was felt that leaving virtual, which is at the beginning, would make it more readable. If virtual existed before, it was not removed simply because override was added, but if neither virtual nor override existed and override applied because the function was virtual in a base class, then only override was added.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 16, 2025
@github-actions
Copy link

github-actions bot commented Mar 16, 2025

CLANG-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Mar 16, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 16, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@feldergast feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 18, 2025
@github-actions github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025
@github-actions
Copy link

github-actions bot commented Mar 23, 2025

CLANG-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Mar 23, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Mar 23, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@feldergast feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025
@github-actions github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

CLANG-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 2, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Apr 6, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

@github-actions github-actions bot removed AT: CLANG-FORMAT PASS AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 6, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

CMAKE-FORMAT TEST - PASSED

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 6, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

CMAKE-FORMAT TEST - PASSED

@github-actions
Copy link

github-actions bot commented Apr 6, 2025

CLANG-FORMAT TEST - PASSED

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 18, 2025
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CLANG-FORMAT TEST - PASSED

@github-actions github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Apr 18, 2025
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CMAKE-FORMAT TEST - PASSED

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 18, 2025
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CLANG-FORMAT TEST - PASSED

@github-actions github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Apr 18, 2025
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1981
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1937
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1936
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 884
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 736
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 690
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 503
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 309
  • Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)
  • Branch: override
  • SHA: 3fc14b8
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: 903a1d77fa18f5371976ef094d7fa2b97228f116
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: 036c12926d1b4f996cf909eb5b3be053735bab2a
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: c5a44af99bcec2e537d8049690018160907101c3
  • Mode: SUPPORT_REPO

Pull Request Author: leekillough

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1981
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1937
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1936
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 884
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 736
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 690
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

  • Build Num: 503
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

  • Build Num: 309
  • Status: PASSED

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ feldergast ]!

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

3 similar comments
@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@sst-autotester
Copy link
Contributor

sst-autotester commented Apr 19, 2025

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@feldergast feldergast merged commit 89e4bf1 into sstsimulator:devel Apr 19, 2025
7 checks passed
@leekillough leekillough deleted the override branch May 11, 2025 08:12
berquist added a commit to berquist/sst-core that referenced this pull request Aug 15, 2025
@berquist
Remove incorrect rev for sstsimulator#1261 already handled later in t…
308df84 
…he file
feldergast pushed a commit that referenced this pull request Aug 18, 2025
@berquist
Update .git-blame-ignore-revs (#1402)
b7a9bd3 
* Add revision for #1383

* Fix revision for #1253

* Remove incorrect rev for #1261 already handled later in the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feldergast feldergast feldergast approved these changes

Assignees

No one assigned

Labels

AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leekillough @sst-autotester @feldergast