Skip to content

Try to fix readthedocs build #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 22, 2025
Merged

Try to fix readthedocs build #830

merged 6 commits into from
Sep 22, 2025

Conversation

@jsignell
Copy link
Member

I noticed that readthedocs has been failing (https://app.readthedocs.org/projects/pystac-client/builds/28904005/) for a while now. Not totally sure how to test this but it is based off of https://docs.readthedocs.com/platform/stable/build-customization.html#install-dependencies-with-uv which seems like a pretty good source of truth ¯_(ツ)_/¯

@jsignell
Copy link
Member Author

Ok so I think it's specifically building htmlzip that is failing. That's why it is working on PRs but not on releases. If this passes I propose merging it and seeing if readthedocs builds successfully off main.

@jsignell jsignell requested a review from gadomski September 19, 2025 20:19
gadomski
gadomski approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the RTD side:

Image

@gadomski gadomski merged commit 801e369 into main Sep 22, 2025
14 checks passed
@gadomski gadomski deleted the readthedocs branch September 22, 2025 12:47
@jsignell
Copy link
Member Author

Yeah it was working on PRs just not on main and releases but it looks like this fixed it! https://app.readthedocs.org/projects/pystac-client/builds/?version__slug=latest

Now the question is how to build releases that we missed. I guess I could cherry pick this fix to the tag? Or maybe it's just not worth worrying about...

jsignell added a commit to stac-utils/pystac that referenced this pull request Sep 22, 2025
@jsignell
Fix readthedocs build like stac-utils/pystac-client#830
e8fbd9d
@jsignell jsignell mentioned this pull request Sep 22, 2025
Closed
@gadomski
Copy link
Member

Now the question is how to build releases that we missed. I guess I could cherry pick this fix to the tag? Or maybe it's just not worth worrying about...

I'm kind of inclined to not bother, but push a new release to get new docs up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsignell @gadomski