add spatial intervals validation #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
May 22, 2025
stac_pydantic/collection.py
Outdated
|
|
||
| # if bbox is crossing the Antimeridian limit we move xmax to the west | ||
| if xmin > xmax: | ||
| xmax = 180 - (xmax % 360) |
|
😬 I'm not checking for case when sub-sequent intervals are on the right side 😓 
and the current implementation won't work |
gadomski
reviewed
May 22, 2025
gadomski
reviewed
May 23, 2025
stac_pydantic/collection.py
Outdated
Comment on lines
75
to
78
| # │ │ ┌──────┐ │ ┌─────────┐ │ │ | ||
| # └──│──► 2 │ │ │ 1 │ │ │ | ||
| # │ │ │ │ │ │◄────│────────┘ | ||
| # │ └──────┘ │ └─────────┘ │ |
There was a problem hiding this comment.
The left case is:
xmax < xmin_sub and xmax < xmax_subRight case is:
xmin > xmin_xub and xmin > xmax_subMiddle case is:
xmax < xmax_sub and xmin < xmin_sub
Co-authored-by: Pete Gadomski <[email protected]>
Co-authored-by: Pete Gadomski <[email protected]>
Co-authored-by: Pete Gadomski <[email protected]>
Co-authored-by: Pete Gadomski <[email protected]>
gadomski
reviewed
May 27, 2025
stac_pydantic/collection.py
Outdated
| raise error_msg | ||
|
|
||
| # case 1 | ||
| elif xmax_sub <= 0 and xmax_sub > xmax: |
There was a problem hiding this comment.
Suggested change
| elif xmax_sub <= 0 and xmax_sub > xmax: | |
| elif xmax_sub > xmax or xmin_sub > xmax: |
stac_pydantic/collection.py
Outdated
| raise error_msg | ||
|
|
||
| # case 2 | ||
| elif xmin_sub >= 0 and xmin_sub < xmin: |
There was a problem hiding this comment.
Suggested change
| elif xmin_sub >= 0 and xmin_sub < xmin: | |
| elif xmin_sub < xmin or xmax_sub < xmin: |
|
@gadomski I've added more comments to explain the reasoning for the |
gadomski
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #177