Skip to content

Only add GCC Clang warnings options in GCC/Clang #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2025
Merged

Only add GCC Clang warnings options in GCC/Clang #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0640094
Only add GCC Clang warnings options in GCC/Clang
traversaro Sep 12, 2025
8de470f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 12, 2025
c606b7b
Apply suggestions from code review
traversaro Sep 12, 2025
6d1da52
Only add GCC Clang warnings options in GCC/Clang
traversaro Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,11 @@ set(${PROJECT_NAME}_HEADERS
include/${PROJECT_NAME}/eiquadprog-utils.hxx)

add_library(${PROJECT_NAME} src/eiquadprog-fast.cpp src/eiquadprog.cpp)
target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion"
)# We have a lot of implicit size_t to Eigen::Index conversions

if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
# We have a lot of implicit size_t to Eigen::Index conversions
target_compile_options(${PROJECT_NAME} PRIVATE "-Wno-sign-conversion")
endif()

if(TRACE_SOLVER)
target_compile_definitions(${PROJECT_NAME} PRIVATE EIQGUADPROG_TRACE_SOLVER)
Expand Down
14 changes: 8 additions & 6 deletions tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,16 @@ set(TESTS eiquadprog-basic eiquadprog-fast eiquadprog-rt eiquadprog-both
foreach(test ${TESTS})
add_unit_test(${test} ${test}.cpp)
target_link_libraries(${test} ${PROJECT_NAME} Boost::unit_test_framework)
target_compile_options(
${test} PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t
# to Eigen::Index conversions
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
# We have a lot of implicit size_t to Eigen::Index conversions
target_compile_options(${test} PRIVATE "-Wno-sign-conversion")
endif()
endforeach(test ${TESTS})

add_library(testab SHARED TestA.cpp TestB.cpp)
target_link_libraries(testab ${PROJECT_NAME})
target_link_libraries(test-integration testab)
target_compile_options(
testab PRIVATE "-Wno-sign-conversion") # We have a lot of implicit size_t to
# Eigen::Index conversions
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
# We have a lot of implicit size_t to Eigen::Index conversions
target_compile_options(testab PRIVATE "-Wno-sign-conversion")
endif()
Loading