-
Notifications
You must be signed in to change notification settings - Fork 27
Only add GCC Clang warnings options in GCC/Clang #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi ! This project doesn't usually accept pull requests on the main branch. |
|
thanks for this :) |
No problem! I will iterate parallelly in conda-forge/eiquadprog-feedstock#15, I suspect this is not the only Windows-related change. |
nim65s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format nit + avoid CMAKE_COMPILER_IS_GNUCC deprecated in 3.24
Co-authored-by: Guilhem Saurel <[email protected]>
nim65s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@traversaro : is it OK for you if I squash merge now ?
|
conda-forge/eiquadprog-feedstock#15 seems to be working fine.
Yes, thanks! I love anything that avoids me to manually curate commits. :D |
No description provided.