Skip to content

Conversation

@jcarpent
Copy link
Contributor

@jcarpent jcarpent commented Oct 3, 2025

Thanks for taking the time to make and fill out this pull request!

Description

Checklist

  • I have run pre-commit run --all-files or pixi run lint
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have made corresponding changes to the doxygen documentation
  • I have added tests that prove my fix or feature works
  • I have updated the CHANGELOG or added the "no changelog" label if it's a CI-related issue
  • I have updated the README credits section

@jcarpent jcarpent marked this pull request as draft October 3, 2025 12:54
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@jcarpent jcarpent requested review from jorisv and nim65s October 3, 2025 13:04
@jcarpent
Copy link
Contributor Author

jcarpent commented Oct 3, 2025

@nim65s Following a recommendation made by @jorisv, could you please add the support of Eigen5 in Nix?

@nim65s
Copy link
Contributor

nim65s commented Oct 16, 2025

I've added a nix job with eigen 5, without python, casadi & coal.
I've also checked that it is failing as expected if a EIGEN_NOEXCEPT is not replaced by noexcept:

In file included from /build/source/unittest/tridiagonal-matrix.cpp:7:
/build/source/include/pinocchio/math/tridiagonal-matrix.hpp:263:41: error: expected ';' at end of member declaration
  263 |     EIGEN_CONSTEXPR Eigen::Index rows() const EIGEN_NOEXCEPT
      |                                         ^~~~~
      |                                              ;
/build/source/include/pinocchio/math/tridiagonal-matrix.hpp:263:47: error: 'EIGEN_NOEXCEPT' does not name a type
  263 |     EIGEN_CONSTEXPR Eigen::Index rows() const EIGEN_NOEXCEPT
      |                                               ^~~~~~~~~~~~~~

Random number generation algorithm has changed in Eigen5.
Some non robust tests are not passing because of that.
Copy link
Contributor

@jorisv jorisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casadi support is not working

@jorisv
Copy link
Contributor

jorisv commented Oct 21, 2025

Casadi support is fixed now.
I can't test easily python binding since I would have to rebuild eigenpy.
Do we merge even if the support is partial ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants