-
Notifications
You must be signed in to change notification settings - Fork 476
Add color support for robot meshes in Viser #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexyLegrand
wants to merge
15
commits into
stack-of-tasks:devel
Choose a base branch
from
AlexyLegrand:collada-parser
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
be2587c
add solution to load collada
f760906
add solution to load collada
2347877
fix default color handling in viser_visualizer.py
ea797d4
change the default robot in viser-viewer.py to test
68c539c
change the function add_mesh_from_path to load color with collada
ac14f5f
Ensure all geometry types are correctly handled to prevent NoneType e…
9decb6c
Ensure all geometry types are correctly handled to prevent NoneType e…
7e2e7a9
handle incorrect faces array shape in COLLADA mesh loading
16c3bed
improved handling of geometry indices (added explicit checks and resh…
e0bfdf1
use pathlib instead of os.path and add comments
bcf1681
restore default robot after testing
e98d328
remove useless print
446c658
remove extra spaces
b8e5274
simplify face indices normalization logic
ea7a881
add helper function to make the code more understandable
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.