Skip to content

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Jan 22, 2025

Description

Fixes #292

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
- [x] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr
Copy link
Contributor Author

nightkr commented Jan 22, 2025

Release note:

Pod enrichment [FIXME: change this to /24.11 in the actual release notes] has now been removed, after being deprecated in 24.11. Remaining users are encouraged to migrate to the Stackable Listener Operator instead, which makes fewer assumptions around how the Pod should be accessed.

@nightkr nightkr requested a review from a team January 22, 2025 14:07
sbernauer
sbernauer previously approved these changes Jan 22, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only on minor nit

sbernauer
sbernauer previously approved these changes Jan 22, 2025
@sbernauer
Copy link
Member

@nightkr watch out, pre-commit failed

@nightkr nightkr added this pull request to the merge queue Jan 22, 2025
@nightkr nightkr removed this pull request from the merge queue due to a manual request Jan 22, 2025
@nightkr
Copy link
Contributor Author

nightkr commented Jan 22, 2025

Goddamnit.. fixed.

@nightkr nightkr enabled auto-merge January 22, 2025 14:43
@nightkr nightkr requested a review from sbernauer January 22, 2025 14:43
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nightkr nightkr added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ef430d1 Jan 22, 2025
17 checks passed
@nightkr nightkr deleted the chore/drop-pod-enrichment branch January 22, 2025 14:58
Techassi added a commit that referenced this pull request Jan 27, 2025
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
Techassi added a commit that referenced this pull request Jan 27, 2025
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2025
The faulty change was introduced in 4b14f04 for PR #321. Came up in
stackabletech/documentation#703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop pod enrichment controller

3 participants