Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jun 11, 2025

Description

Part of: stackabletech/spark-k8s-operator#582

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 12, 2025
@razvan razvan requested a review from a team June 12, 2025 13:34
@maltesander maltesander self-requested a review June 13, 2025 08:59
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 13, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, worth a changelog entry?

@razvan
Copy link
Member Author

razvan commented Jun 13, 2025

LGTM, worth a changelog entry?

Thanks. Done.

@razvan razvan requested a review from maltesander June 13, 2025 09:13
@razvan razvan enabled auto-merge June 13, 2025 09:13
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit b53fedf Jun 13, 2025
3 checks passed
@razvan razvan deleted the feat/spark-no-jmx-exporter branch June 13, 2025 09:35
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Jun 13, 2025
razvan added a commit that referenced this pull request Jun 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2025
Revert "chore(spark): remove jmx exporter (#1157)"

This reverts commit b53fedf.
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants