Skip to content

Backport NIFI-14858 to NiFi 2.4.0 #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Backport NIFI-14858 to NiFi 2.4.0 #1225

merged 1 commit into from
Aug 15, 2025

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Aug 13, 2025

Description

This allows to manually work around stackabletech/nifi-operator#812 by applying NIFI-14848 to NiFi 2.4.0.

It allows disabling of SNI checks for NiFi 2.x

How this was tested

I did run the image build and we tested it manually on a cluster with an Ingress.
Without config overrides we'd get an error accessing NiFi.
With the config overrides it works:

nodes:
  configOverrides:
    nifi.properties:
      nifi.web.https.sni.required: "false"
      nifi.web.https.sni.host.check: "false"

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Add an entry to the CHANGELOG.md file
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Aug 13, 2025
@sbernauer
Copy link
Member

nit: I think we should remove the "Backport" from the PR title, no that the chances of it getting merged are very small

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I dont feel this will be fixed upstream so i would rename the PR and changelog entry as @sbernauer suggested and merge?

@lfrancke lfrancke added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit e30798a Aug 15, 2025
3 checks passed
@lfrancke lfrancke deleted the feat/NIFI-14848 branch August 15, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: In Review
Development

Successfully merging this pull request may close these issues.

3 participants