fix: pin luxon to fix build #1315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building Superset 4.1.2 and 4.1.4 currently fails.
For some reason, npm tries to use a newer version of
luxonthan the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files, some dependencies do not seem to be locked. When I create the lock file with npm 11, way more dependencies are locked. I decided not to commit the lock file generated by npm 11 though, because the diff would be huge and some package versions would have changed. That's why theluxonversion is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used and building works again, without changing too much. We can reconsider another fix for this if this happens again.Local build succeeded and smoke test passed.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.