Skip to content

Conversation

@dervoeti
Copy link
Member

@dervoeti dervoeti commented Oct 22, 2025

Description

Building Superset 4.1.2 and 4.1.4 currently fails.

For some reason, npm tries to use a newer version of luxon than the version in the lock file. I suspect this might be related to how npm before version 11 handles workspace dependencies in lock files, some dependencies do not seem to be locked. When I create the lock file with npm 11, way more dependencies are locked. I decided not to commit the lock file generated by npm 11 though, because the diff would be huge and some package versions would have changed. That's why the luxon version is set to 3.6.1 now to prevent npm from trying to select a newer version, so that the same packages as in the original Superset build are used and building works again, without changing too much. We can reconsider another fix for this if this happens again.

Local build succeeded and smoke test passed.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Oct 23, 2025
@dervoeti dervoeti self-assigned this Oct 23, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a mess :)

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 23, 2025
@dervoeti dervoeti added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit bb35a87 Oct 23, 2025
3 checks passed
@dervoeti dervoeti deleted the fix/superset-41x-build-npm-ci branch October 23, 2025 07:02
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Oct 23, 2025
@dervoeti dervoeti mentioned this pull request Oct 23, 2025
6 tasks
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants