Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Part of stackabletech/issues#594

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@sbernauer sbernauer enabled auto-merge July 3, 2024 09:48
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer sbernauer added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 33d5cd5 Jul 3, 2024
@sbernauer sbernauer deleted the chore/bump-base-dependencies branch July 3, 2024 09:49

# Manifest list digest because of multi architecture builds ( https://www.redhat.com/architect/pull-container-image#:~:text=A%20manifest%20list%20exists%20to,system%20on%20a%20specific%20architecture )
FROM registry.access.redhat.com/ubi9/ubi-minimal@sha256:a7d837b00520a32502ada85ae339e33510cdfdbc8d2ddf460cc838e12ec5fa5a AS final
FROM registry.access.redhat.com/ubi9-minimal@sha256:a7d837b00520a32502ada85ae339e33510cdfdbc8d2ddf460cc838e12ec5fa5a AS final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They where not needed, we just wanted to switch to what we think is the new naming scheme to be safe going forward

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I changed it back in #807 (because that's how it appears at the linked site I have added in my PR 🤷)

Note: @sbernauer did ask me about this and I double checked the commit hashes match.

NickLarsenNZ added a commit to stackabletech/operator-rs that referenced this pull request Jul 9, 2024
github-merge-queue bot pushed a commit to stackabletech/operator-rs that referenced this pull request Jul 9, 2024
* chore: bump rust-toolchain to 1.79.0

ubiX-rust-builder images updated in stackabletech/docker-images#737

* chore: bump dependencies

* chore: update ref in changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants