Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Sep 16, 2024

Description

part of #837

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan requested a review from a team September 16, 2024 09:12
@razvan razvan enabled auto-merge September 16, 2024 12:05
sbernauer
sbernauer previously approved these changes Sep 17, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % 1 comment

@sbernauer sbernauer disabled auto-merge September 17, 2024 11:22
@razvan razvan added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit c977d8c Sep 17, 2024
2 checks passed
@razvan razvan deleted the chore/superset-24.11 branch September 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants