Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Sep 25, 2024

Description

Add the Spark HBase connector

part of #870

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [x] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [x] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [x] All packages should have (if available) signatures/hashes verified
- [x] Add an entry to the CHANGELOG.md file
- [x] Integration tests ran successfully (stackabletech/spark-k8s-operator#471)
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@siegfriedweber siegfriedweber marked this pull request as ready for review September 25, 2024 13:01
@siegfriedweber siegfriedweber requested a review from a team September 25, 2024 13:02
@razvan razvan requested review from razvan and removed request for a team September 26, 2024 14:09
razvan
razvan previously approved these changes Sep 26, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Ididn't attempt to build it locally. I trust it worked for you.

Co-authored-by: Razvan-Daniel Mihai <[email protected]>
@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 29, 2024
Merged via the queue into main with commit 411bd57 Sep 29, 2024
2 checks passed
@siegfriedweber siegfriedweber deleted the feat/spark-hbase-connector branch September 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants