Skip to content

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Sep 25, 2024

Description

Add an integration test for the HBase connector

Tests stackabletech/docker-images#878

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] Integration tests passed (for non trivial changes)
- [x] `test-definition.yaml` does not contain custom images
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Sep 25, 2024

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Minio chart values are leftovers that can be removed right ?

It looks good to me. Waiting for the new images to be published to approve,

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siegfriedweber siegfriedweber added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 0a8bf49 Oct 1, 2024
31 checks passed
@siegfriedweber siegfriedweber deleted the test/hbase-connector branch October 1, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants