Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Oct 17, 2024

Description

prere-quisite for : stackabletech/hbase-operator#570

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan requested a review from a team October 17, 2024 13:58
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 17, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan requested a review from NickLarsenNZ October 18, 2024 13:52
@razvan razvan self-assigned this Oct 21, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we aren't blocked, but would like some light docs on the traps/signal handlin.

@razvan razvan added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit dff82c6 Oct 23, 2024
2 checks passed
@razvan razvan deleted the hbase/entrypoint branch October 23, 2024 08:02
@lfrancke
Copy link
Member

@razvan would we revert this if we decide not to merge the other related graceful shutdown tickets?

@razvan
Copy link
Member Author

razvan commented Nov 13, 2024

It's not used and has no impact if it stays.

Personally I would prefer to create entry point scripts for all products and get rid of the hard-coded shell snippets in the operators.

But if it bothers you, I can revert it.

@lfrancke
Copy link
Member

It doesn't. I was just wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants