-
-
Notifications
You must be signed in to change notification settings - Fork 6
feat(hbase): add hbase-entrypoint.sh script #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so we aren't blocked, but would like some light docs on the traps/signal handlin.
@razvan would we revert this if we decide not to merge the other related graceful shutdown tickets? |
It's not used and has no impact if it stays. Personally I would prefer to create entry point scripts for all products and get rid of the hard-coded shell snippets in the operators. But if it bothers you, I can revert it. |
It doesn't. I was just wondering. |
Description
prere-quisite for : stackabletech/hbase-operator#570
Definition of Done Checklist
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.