feat(regionserver): add graceful shutdown configuration #570

razvan · 2024-10-02T11:39:51Z

Description

part of: #508

requires: stackabletech/docker-images#898

Implementation for "approach B" in https://github.com/stackabletech/decisions/issues/30

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [x] Code contains useful comments
- [x] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Extract region configuration into it's own structure. Refactor the lib and controller modules to work with the new structure in a slightly generic way.

NickLarsenNZ

Partial review

docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc

rust/crd/src/affinity.rs

rust/crd/src/lib.rs

…own.adoc Co-authored-by: Nick <[email protected]>

siegfriedweber

LGTM

razvan · 2025-01-17T11:15:40Z

Updated and it now requires stackabletech/docker-images#974

CHANGELOG.md

tests/templates/kuttl/shutdown/30-install-hbase.yaml.j2

tests/test-definition.yaml

Co-authored-by: Siegfried Weber <[email protected]>

siegfriedweber

LGTM

Outdated

razvan · 2025-02-06T08:42:10Z

LGTM

Thanks!

sbernauer · 2025-02-07T10:33:44Z

deploy/helm/hbase-operator/crds/crds.yaml

+                        hbaseOpts:
+                          nullable: true
+                          type: string


I think this should not be added again (applies to all roles).
#620 removed it, can you please remove it again?

sbernauer · 2025-02-07T10:40:31Z

rust/operator-binary/src/config/jvm.rs


-/// JVM arguments that specifically for the role (server), so will *not* be used e.g. by CLI tools
-fn construct_role_specific_jvm_args(
+/// Arguments that go into `HBASE_OPTS`, so *not* the heap settings (which go into `HBASE_HEAPSIZE`).


Actually they are role specific, so they do not go into HBASE_OPTS.
Instead they go into HBASE_MASTER_OPTS and others

Maybe something like

/// JVM arguments that are specifically for the role (server), so will *not* be used e.g. by CLI tools. /// Heap settings are excluded, as they go into `HBASE_HEAPSIZE`.

razvan added 9 commits October 2, 2024 14:37

feat(regionserver): add graceful shutdown configuration

4ad793f

Extract region configuration into it's own structure. Refactor the lib and controller modules to work with the new structure in a slightly generic way.

Make UnifiedRoleConfiguration a sub-trait of Send

cb232df

Replace trait with enum.

dea179d

implement region mover command

eecaf23

fix: crd field names

0b14f92

unit tests and shell escaping

71793ea

update docs

1644aff

spelling

1903f36

cargo update

5e8201f

razvan marked this pull request as ready for review October 14, 2024 16:24

razvan requested a review from a team October 14, 2024 16:24

razvan self-assigned this Oct 15, 2024

razvan mentioned this pull request Oct 15, 2024

feat: graceful(er) server shutdown #568

Closed

razvan marked this pull request as draft October 15, 2024 15:53

razvan added 5 commits October 16, 2024 18:00

added shutdown test & hbase-entrypoint.sh

e76166a

cleanup and set region mover opts env var

3c63da1

main merge

69a6f49

first successful integration test

8dbde9b

main merge

68756ab

razvan mentioned this pull request Oct 17, 2024

feat(hbase): add hbase-entrypoint.sh script stackabletech/docker-images#898

Merged

razvan marked this pull request as ready for review October 17, 2024 13:58

fix image pull policy for the kerberos tests

43abf6d

NickLarsenNZ reviewed Oct 17, 2024

View reviewed changes

razvan and others added 7 commits October 17, 2024 17:23

add RUN_REGION_MOVER env var

2b6e89b

Update docs/modules/hbase/pages/usage-guide/operations/graceful-shutd…

c53497a

…own.adoc Co-authored-by: Nick <[email protected]>

remove trailing whitespace in docs

4e31a3c

rust : remove unused dep

a10caa0

fix shellcheck lint

f42ab05

update shutdown test and run it successfuly

0e9e37e

update docs

c2c92c5

fix: RegionMover fields should not be Optional

d6d5fe4

siegfriedweber previously approved these changes Oct 31, 2024

View reviewed changes

main merge

fa239e5

razvan dismissed siegfriedweber’s stale review via fa239e5 January 15, 2025 11:32

add STACKABLE_LOG_DIR env var

cb76f4e

razvan mentioned this pull request Jan 15, 2025

fix: hbase entry point uses log dir env var stackabletech/docker-images#974

Merged

ref introduce const CONTAINERDEBUG_LOG_DIRECTORY

e86b446

razvan added 7 commits January 30, 2025 15:35

main merge

cd22ba8

make shutdown test more resilient

ab00b89

main merge

19db6a9

Merge branch 'main' into feat/region-mover

a6facad

tmp test def

6cbe265

update rustfmt

7c9a5bd

main merge

2123fbc

siegfriedweber requested changes Feb 5, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tests/templates/kuttl/shutdown/30-install-hbase.yaml.j2 Outdated Show resolved Hide resolved

tests/test-definition.yaml Outdated Show resolved Hide resolved

razvan and others added 3 commits February 5, 2025 18:45

Update tests/templates/kuttl/shutdown/30-install-hbase.yaml.j2

ace488a

Co-authored-by: Siegfried Weber <[email protected]>

revert test definition

ca3f734

update changelog

76001c5

razvan requested a review from siegfriedweber February 5, 2025 17:48

siegfriedweber approved these changes Feb 6, 2025

View reviewed changes

razvan added this pull request to the merge queue Feb 6, 2025

Merged via the queue into main with commit 6e3eef5 Feb 6, 2025
17 checks passed

razvan deleted the feat/region-mover branch February 6, 2025 08:45

sbernauer reviewed Feb 7, 2025

View reviewed changes

sbernauer mentioned this pull request Feb 7, 2025

fix: region mover merging oversight #626

Merged

lfrancke added the release/25.3.0 label Feb 16, 2025

Uh oh!

feat(regionserver): add graceful shutdown configuration #570

feat(regionserver): add graceful shutdown configuration #570

Uh oh!

Conversation

razvan commented Oct 2, 2024 • edited by siegfriedweber Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Definition of Done Checklist

Uh oh!

NickLarsenNZ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siegfriedweber left a comment

Choose a reason for hiding this comment

Uh oh!

razvan commented Jan 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siegfriedweber left a comment

Choose a reason for hiding this comment

Uh oh!

razvan commented Feb 6, 2025

Uh oh!

Uh oh!

sbernauer Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

sbernauer Feb 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

razvan commented Oct 2, 2024 •

edited by siegfriedweber

Loading