Skip to content

Conversation

razvan
Copy link
Member

@razvan razvan commented Dec 9, 2024

  • feat: requestedSecretLifetime role group property added
  • Update rust/crd/src/lib.rs
  • Update CHANGELOG.md
  • implement review feedback
  • Update CHANGELOG.md
  • point to op-rs main
  • apply review patch
  • apply review patch 2
  • chore: bump op-rs
  • cargo update -p rustls
  • fix: revert default secret lifetime to 1 day

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@razvan razvan self-assigned this Dec 9, 2024
@razvan razvan requested a review from a team December 9, 2024 08:30
@razvan razvan enabled auto-merge December 9, 2024 10:06
@sbernauer sbernauer changed the title fix: revert the default secret lifetime to 1 day fix: revert default secret lifetime to 1 day Dec 9, 2024
@razvan razvan added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 251090d Dec 9, 2024
16 of 17 checks passed
@razvan razvan deleted the secret-lifetime-1d branch December 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants