Skip to content

fix: revert default secret lifetime to 1 day #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 9, 2024
Merged

fix: revert default secret lifetime to 1 day #604

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d313a45
feat: `requestedSecretLifetime` role group property added
razvan Nov 28, 2024
ad277a7
Update rust/crd/src/lib.rs
razvan Nov 29, 2024
e8c517e
Update CHANGELOG.md
razvan Nov 29, 2024
2d36812
implement review feedback
razvan Nov 29, 2024
752f91e
Update CHANGELOG.md
razvan Nov 29, 2024
a308e8d
point to op-rs main
razvan Dec 2, 2024
9cdf652
apply review patch
razvan Dec 2, 2024
8c4387a
apply review patch 2
razvan Dec 2, 2024
8a23ef1
Merge branch 'main' into feat/issue-586
razvan Dec 3, 2024
407dc01
chore: bump op-rs
razvan Dec 3, 2024
8ea48b6
cargo update -p rustls
razvan Dec 4, 2024
629934b
fix: revert default secret lifetime to 1 day
razvan Dec 9, 2024
a494ff6
merge main
razvan Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rust/crd/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ impl HbaseRole {
Duration::from_minutes_unchecked(5);

// Auto TLS certificate lifetime
const DEFAULT_MASTER_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(7);
const DEFAULT_REGION_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(7);
const DEFAULT_REST_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(7);
const DEFAULT_MASTER_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(1);
const DEFAULT_REGION_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(1);
const DEFAULT_REST_SECRET_LIFETIME: Duration = Duration::from_days_unchecked(1);

pub fn default_config(
&self,
Expand Down
Loading