fix: Default external-unstable ListenerClass back to IPs #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
reviewed
Oct 31, 2024
Contributor
nightkr
left a comment
nightkr
left a comment
There was a problem hiding this comment.
Hm, another alternative would be to add some "auto" mode to preferredAddressType that reverts to the old behaviour, so we avoid the breakage entirely.
Comment on lines
+64
to
+67
| # As the nodes have stable addresses we expect them to have hostnames that are resolvable outside of Kubernetes. | ||
| # And yes, we know this causes problems when running on kind with the stable-nodes preset (default), as the kind node | ||
| # hostname is very likely not resolvable on the host machine. | ||
| preferredAddressType: Hostname |
Contributor
There was a problem hiding this comment.
This should poobably match external-unstable
Comment on lines
+44
to
+48
| # Ideally we would prefer the Hostname here, but up to (including) SDP 24.7 we defaulted to the IP. | ||
| # We actually defaulted to Hostname for some weeks, but noticed this breaks external access to kind clusters, as the | ||
| # local machines can not resolve the hostnames of the nodes (such as kind-control-plane). | ||
| # So we stick to the old default and re-visit the default later - after SDP 24.11 is released. | ||
| preferredAddressType: IP |
Contributor
There was a problem hiding this comment.
This makes it sound like a temporary migration measure, but I suspect pretty heavily that we'll want to make this permanent.
1 task
Member
Author
|
Superseded by #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasoning is on the code comments and changelog.
Relevant discussion: https://stackable-workspace.slack.com/archives/C0312UB3LLE/p1730312706917569?thread_ts=1730298381.528779&cid=C0312UB3LLE
Definition of Done Checklist