Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 25, 2025

Description

We currently have a bug that opa-bundle-builder or user-info-fetcher take an ProductOperatorRun, causing

bundle-builder error: the following required arguments were not provided:                                                                                                
bundle-builder   --operator-namespace <OPERATOR_NAMESPACE>                                                                                                               
bundle-builder   --operator-service-name <OPERATOR_SERVICE_NAME>                                                                                                         
bundle-builder                                                                                                                                                           
bundle-builder Usage: stackable-opa-bundle-builder --operator-namespace <OPERATOR_NAMESPACE> --operator-service-name <OPERATOR_SERVICE_NAME> --kubernetes-node-name <KUBE
RNETES_NODE_NAME> --watch-namespace <WATCH_NAMESPACE> --file-log-directory <DIRECTORY> --kubernetes-cluster-domain <KUBERNETES_CLUSTER_DOMAIN> 

We could create a custom struct in every tool (we did that for some tools in the past), but it makes sense to have it as a common struct.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Aug 25, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 25, 2025
@sbernauer sbernauer requested a review from a team August 25, 2025 08:47
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 25, 2025
@sbernauer sbernauer changed the title feat!: Add CommonStackableCliArgs struct feat!: Add cli::CommonOptions struct Aug 25, 2025
@sbernauer sbernauer requested a review from Techassi August 25, 2025 08:59
@sbernauer sbernauer added this pull request to the merge queue Aug 25, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2025
@sbernauer sbernauer added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit b48779e Aug 25, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/common-stackable-cli-args branch August 25, 2025 09:21
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants