Skip to content

Conversation

sbernauer
Copy link
Member

Description

Noticed in https://testing.stackable.tech/job/superset-operator-it-weekly/69

create Pod superset-node-default-0 in StatefulSet superset-node-default failed error: Pod "superset-node-default-0" is invalid: [spec.containers[0].livenessProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0, spec.containers[0].readinessProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0, spec.containers[0].readinessProbe.terminationGracePeriodSeconds: Invalid value: 0: must not be set for readinessProbes, spec.containers[0].startupProbe.terminationGracePeriodSeconds: Invalid value: 0: must be greater than 0]

Also copy some docs from k8s docs

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this Sep 8, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Sep 8, 2025
@sbernauer sbernauer requested a review from a team September 8, 2025 06:44
@maltesander maltesander self-requested a review September 8, 2025 06:48
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 8, 2025
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, LGTM otherwise!

@sbernauer
Copy link
Member Author

Thanks! Somehow my VSCode behavior on quotes changed....

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Sep 8, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Sep 8, 2025
Merged via the queue into main with commit 6a5a2ac Sep 8, 2025
8 checks passed
@sbernauer sbernauer deleted the fix/probe-termination-grace-period branch September 8, 2025 08:15
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 8, 2025
sbernauer added a commit to stackabletech/superset-operator that referenced this pull request Sep 11, 2025
github-merge-queue bot pushed a commit to stackabletech/superset-operator that referenced this pull request Sep 12, 2025
* fix: Invalid terminationGracePeriod in probes

Pulls in stackabletech/operator-rs#1090

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants