Skip to content

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Jun 18, 2025

Description

Part of stackabletech/issues#735
Trino already provides built-in Prometheus metrics per default. This PR adds testing the metrics endpoint and some documentation.

--- FAIL: kuttl (2045.00s)
    --- FAIL: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (417.36s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (435.47s)
        --- PASS: kuttl/harness/smoke_trino-476_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (426.37s)
        --- FAIL: kuttl/harness/smoke_trino-476_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (1182.69s)
        --- FAIL: kuttl/harness/smoke_trino-470_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (1110.19s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (426.83s)
FAIL
ERROR:root:kuttl failed

--- PASS: kuttl (409.49s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (409.48s)
PASS

--- PASS: kuttl (373.74s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-476_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (373.73s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Jun 18, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 18, 2025
@razvan razvan self-requested a review June 18, 2025 14:19
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 18, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AWS metrics test will not work like this but I'm personally also fine if you remove it.

@xeniape xeniape requested a review from razvan June 19, 2025 07:22
@xeniape
Copy link
Member Author

xeniape commented Jun 20, 2025

Metrics test was faulty and wasn't really testing anything. Fixed in b064649

--- PASS: kuttl (1198.39s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (374.15s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (423.63s)
        --- PASS: kuttl/harness/smoke_trino-476_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (377.99s)
        --- PASS: kuttl/harness/smoke_trino-476_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (406.36s)
        --- PASS: kuttl/harness/smoke_trino-470_hive-3.1.3_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (445.70s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (368.39s)
PASS

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@xeniape xeniape added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 4c758d6 Jun 23, 2025
17 checks passed
@xeniape xeniape deleted the chore/test-and-document-metrics branch June 23, 2025 08:29
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Jun 23, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants