CI: Enable Rocky Linux 9 jobs #185
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request expands the continuous integration test matrix by incorporating jobs for Rocky Linux 9. This ensures that Cephadm deployments are validated on this operating system, covering various container runtimes (Docker and Podman) and Ceph releases (Reef and Squid), thereby enhancing the robustness of the CI pipeline.
Highlights
- CI Job Expansion: New cephadm-rocky9 jobs have been added to the Zuul CI configuration, specifically for multinode-docker-reef, multinode-podman-reef, multinode-docker-squid, and multinode-podman-squid setups. These jobs are included in both the check and gate pipelines.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enables CI jobs for Rocky Linux 9 by adding them to the check and gate queues. The changes look correct and the new jobs are properly defined. My only feedback concerns the duplication of the job list between the check and gate sections. This pull request increases that duplication. I've added a comment with a suggestion to refactor this using YAML anchors to improve maintainability.
| - cephadm-rocky9-multinode-docker-reef | ||
| - cephadm-rocky9-multinode-podman-reef | ||
| - cephadm-rocky9-multinode-docker-squid | ||
| - cephadm-rocky9-multinode-podman-squid |
There was a problem hiding this comment.
These lines duplicate the jobs added to the check queue on lines 11-14. This duplication can make maintenance difficult and error-prone.
To improve this, consider using YAML anchors and aliases to define the list of jobs once and reuse it for both check and gate queues. You can see an example of this pattern in zuul.d/nodesets.yaml.
Since the check queue contains an extra job (tox-linters), you would need to define the common list of jobs. This might require a slight restructuring of the file but will significantly improve maintainability in the long run.
No description provided.