Skip to content

CI: Enable Rocky Linux 9 jobs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: Enable Rocky Linux 9 jobs #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions zuul.d/project.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,18 @@
- cephadm-jammy-multinode-podman-reef
- cephadm-noble-multinode-docker-squid
- cephadm-noble-multinode-podman-squid
- cephadm-rocky9-multinode-docker-reef
- cephadm-rocky9-multinode-podman-reef
- cephadm-rocky9-multinode-docker-squid
- cephadm-rocky9-multinode-podman-squid
- tox-linters
gate:
jobs:
- cephadm-jammy-multinode-docker-reef
- cephadm-jammy-multinode-podman-reef
- cephadm-noble-multinode-docker-squid
- cephadm-noble-multinode-podman-squid
- cephadm-rocky9-multinode-docker-reef
- cephadm-rocky9-multinode-podman-reef
- cephadm-rocky9-multinode-docker-squid
- cephadm-rocky9-multinode-podman-squid
Comment on lines +22 to +25
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These lines duplicate the jobs added to the check queue on lines 11-14. This duplication can make maintenance difficult and error-prone.

To improve this, consider using YAML anchors and aliases to define the list of jobs once and reuse it for both check and gate queues. You can see an example of this pattern in zuul.d/nodesets.yaml.

Since the check queue contains an extra job (tox-linters), you would need to define the common list of jobs. This might require a slight restructuring of the file but will significantly improve maintainability in the long run.

Loading