fix nightly cleanup for duplicate server names #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI cancelled because not tested |
sjpb
requested changes
Apr 22, 2025
There was a problem hiding this comment.
The logic here doesn't work; if you get multiple clusters with the same prefix (b/c of re-runs), and one of them is tagged, this may delete another, untagged cluster with the same prefix.
We've never used the tag feature, I suggest we just drop that entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous nightly cleanup broken for duplicate servers:
https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/14093434777/job/39475494238
New workflow ensures that subsequent cleanup calls for duplicate server names doesn't occur.