Skip to content

fix nightly cleanup for duplicate server names #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

fix nightly cleanup for duplicate server names #653

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4d870d
fix nightly cleanup for duplicate server names
bertiethorpe Apr 22, 2025
8de7d01
remove check for 'keep' tags in nightly cleanup
bertiethorpe Apr 22, 2025
8da423b
simplify cluster deletion
bertiethorpe Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 4 additions & 33 deletions .github/workflows/nightly-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,42 +56,13 @@ jobs:
fi
shell: bash

- name: Delete clusters if control node not tagged with keep
- name: Delete CI clusters
run: |
. venv/bin/activate
if [[ -z ${ci_clusters} ]]; then
if [[ -z "${ci_clusters}" ]]; then
echo "No clusters to delete."
exit 0
fi

for cluster_prefix in ${ci_clusters}
do
echo "Processing cluster: $cluster_prefix"
# Get all servers with the matching name for control node
CONTROL_SERVERS=$(openstack server list --name ${cluster_prefix}-control --format json)
SERVER_COUNT=$(echo "$CONTROL_SERVERS" | jq length)

if [[ $SERVER_COUNT -gt 1 ]]; then
echo "Multiple servers found for control node '${cluster_prefix}-control'. Checking tags for each..."

for server in $(echo "$CONTROL_SERVERS" | jq -r '.[].ID'); do
# Get tags for each control node
TAGS=$(openstack server show "$server" --column tags --format value)

if [[ $TAGS =~ "keep" ]]; then
echo "Skipping ${cluster_prefix} (server ${server}) - control instance is tagged as keep"
else
./dev/delete-cluster.py ${cluster_prefix} --force
fi
done
else
# If only one server, extract its tags and proceed
TAGS=$(echo "$CONTROL_SERVERS" | jq -r '.[0].Tags')
if [[ $TAGS =~ "keep" ]]; then
echo "Skipping ${cluster_prefix} - control instance is tagged as keep"
else
./dev/delete-cluster.py ${cluster_prefix} --force
fi
fi
done
echo "Deleting clusters: ${ci_clusters}"
./dev/delete-cluster.py ${ci_clusters} --force
shell: bash
Loading