Clone Kayobe into a tempdir when doing version checks #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning Kayobe as part of check-kayobe-version.yml would fail with POSIX permission errors when it was run by multiple users, because the clone destination directory is a) always the same and b) never cleaned up. Clone Kayobe into a unique directory each time using ansible.builtin.tempfile and clean up the directory tree when it is no longer needed. This ensures that each user that runs check-kayobe-version.yml gets a Kayobe checkout to a unique path, and not one that already exists and is owned by someone else.
bbezak
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning Kayobe as part of check-kayobe-version.yml would fail with POSIX permission errors when it was run by multiple users, because the clone destination directory is a) always the same and b) never cleaned up.
Clone Kayobe into a unique directory each time using ansible.builtin.tempfile and clean up the directory tree when it is no longer needed. This ensures that each user that runs check-kayobe-version.yml gets a
Kayobe checkout to a unique path, and not one that already exists and is owned by someone else.