Skip to content

Clone Kayobe into a tempdir when doing version checks #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Clone Kayobe into a tempdir when doing version checks #1757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions etc/kayobe/ansible/check-kayobe-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,28 @@
register: kayobe_git_commit
failed_when: kayobe_git_commit.stdout == ""

- name: Create a temporary directory to clone Kayobe into
ansible.builtin.tempfile:
state: directory
register: kayobe_temp_dir

- name: Clone Kayobe
ansible.builtin.git:
repo: https://github.com/stackhpc/kayobe.git
dest: /tmp/kayobe-git
dest: "{{ kayobe_temp_dir.path }}/kayobe-git"
version: stackhpc/{{ openstack_release }}

- name: Get tag from Kayobe commit

Check warning on line 43 in etc/kayobe/ansible/check-kayobe-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.16 lint with Python 3.12

command-instead-of-module 

git used in place of git module

Check warning on line 43 in etc/kayobe/ansible/check-kayobe-version.yml

View workflow job for this annotation

GitHub Actions / Ansible 2.15 lint with Python 3.10

command-instead-of-module 

git used in place of git module
ansible.builtin.command:
cmd: git describe --tags {{ kayobe_git_commit.stdout }}
chdir: /tmp/kayobe-git
chdir: "{{ kayobe_temp_dir.path }}/kayobe-git"
register: kayobe_current_version

- name: Clean up temporary directory
ansible.builtin.file:
state: absent
path: "{{ kayobe_temp_dir.path }}"

- name: Get latest Kayobe version
ansible.builtin.shell:
cmd: set -o pipefail && grep -o kayobe@stackhpc\/.*$ {{ requirements_path }} | cut -d @ -f 2
Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/fix-kayobe-version-checks-d1fb3e09391e4a3e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
Fix Kayobe version checks that were failing on multiuser
Ansible control hosts.
Loading