Fix older periodic multinodes #1812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example outputs: |
Well, at least it didn't fail in the same way |
priteau
requested changes
Aug 6, 2025
There was a problem hiding this comment.
Your refactoring introduces many issues flagged by flake8:
.github/workflows/multinode-inputs.py:9:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:15:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:20:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:27:1: E305 expected 2 blank lines after class or function definition, found 1
.github/workflows/multinode-inputs.py:37:27: E231 missing whitespace after ','
.github/workflows/multinode-inputs.py:37:36: E231 missing whitespace after ','
.github/workflows/multinode-inputs.py:37:45: E231 missing whitespace after ','
.github/workflows/multinode-inputs.py:39:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:45:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:52:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:54:80: E501 line too long (116 > 79 characters)
.github/workflows/multinode-inputs.py:55:80: E501 line too long (92 > 79 characters)
.github/workflows/multinode-inputs.py:64:80: E501 line too long (81 > 79 characters)
.github/workflows/multinode-inputs.py:68:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:71:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:77:1: E302 expected 2 blank lines, found 1
.github/workflows/multinode-inputs.py:80:1: E305 expected 2 blank lines after class or function definition, found 1
Alex-Welsh
force-pushed
the
fix-old-mn-periodic
branch
from
ba97d20 to
e4bc9ea
Compare
Thanks, fixed now. Somewhat ironically, yesterday I was investigating linters for SKC, and thinking about adding one to our standard tox setup, which currently only does release notes. Didn't think to test it here though |
priteau
reviewed
Aug 7, 2025
priteau
force-pushed
the
fix-old-mn-periodic
branch
from
e4bc9ea to
108e874
Compare
Fixed in the version I pushed. |
priteau
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 2 commits
The first is a minor refactor of the periodic Multinode python script (which is not required for the old periodic mn fix)
The second adds a new argument to the workflow invocation, to change the version of terraform-kayobe-multinode. The input already exists.