Skip to content

Fix older periodic multinodes #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Fix older periodic multinodes #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a17ec9b
CI: Multinode version selector logic & linting
Alex-Welsh Aug 6, 2025
108e874
CI: Pin TKM for old periodic multinodes
Alex-Welsh Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions .github/workflows/multinode-inputs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class OSRelease:
@dataclass
class OpenStackRelease:
version: str
previous_version: str
os_releases: t.List[OSRelease]


Expand All @@ -34,11 +33,12 @@ class Scenario:
UBUNTU_NOBLE = OSRelease("ubuntu", "noble", "ubuntu")
# NOTE(upgrade): Add supported releases here.
OPENSTACK_RELEASES = [
OpenStackRelease("2023.1", "zed", [ROCKY_9, UBUNTU_JAMMY]),
OpenStackRelease("2024.1", "2023.1", [ROCKY_9, UBUNTU_JAMMY]),
OpenStackRelease("2025.1", "2024.1", [ROCKY_9, UBUNTU_NOBLE]),
OpenStackRelease("2023.1", [ROCKY_9, UBUNTU_JAMMY]),
OpenStackRelease("2024.1", [ROCKY_9, UBUNTU_JAMMY]),
OpenStackRelease("2025.1", [ROCKY_9, UBUNTU_NOBLE]),
]
NEUTRON_PLUGINS = ["ovs", "ovn"]
VERSION_HIERARCHY = ["zed", "2023.1", "2024.1", "2025.1"]


def main() -> None:
Expand All @@ -52,13 +52,20 @@ def random_scenario() -> Scenario:
openstack_release = random.choice(OPENSTACK_RELEASES)
os_release = random.choice(openstack_release.os_releases)
neutron_plugin = random.choice(NEUTRON_PLUGINS)
upgrade = 'major' if random.random() > 0.6 else 'none'
upgrade = "major" if random.random() > 0.6 else "none"
return Scenario(openstack_release, os_release, neutron_plugin, upgrade)


def generate_inputs(scenario: Scenario) -> t.Dict[str, str]:
branch = get_branch(scenario.openstack_release.version)
previous_branch = get_branch(scenario.openstack_release.previous_version)
previous_branch = get_branch(
VERSION_HIERARCHY[
VERSION_HIERARCHY.index(scenario.openstack_release.version) - 1
]
)
terraform_kayobe_multinode_version = get_tkm_version(
scenario.openstack_release.version
)
inputs = {
"os_distribution": scenario.os_release.distribution,
"os_release": scenario.os_release.release,
Expand All @@ -67,6 +74,7 @@ def generate_inputs(scenario: Scenario) -> t.Dict[str, str]:
"upgrade": scenario.upgrade,
"stackhpc_kayobe_config_version": branch,
"stackhpc_kayobe_config_previous_version": previous_branch,
"terraform_kayobe_multinode_version": terraform_kayobe_multinode_version,
}
return inputs

Expand All @@ -75,6 +83,13 @@ def get_branch(version: str) -> str:
return f"stackhpc/{version}"


def get_tkm_version(version: str) -> str:
if version in ["zed", "2023.1"]:
return "ea61ea1730e179e05e8f0e58b759267664c555e7"
else:
return "main"


def write_output(name: str, value: str) -> None:
print(f"{name}={value}")

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/stackhpc-multinode-periodic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
upgrade: ${{ steps.generate-inputs.outputs.upgrade }}
stackhpc_kayobe_config_version: ${{ steps.generate-inputs.outputs.stackhpc_kayobe_config_version }}
stackhpc_kayobe_config_previous_version: ${{ steps.generate-inputs.outputs.stackhpc_kayobe_config_previous_version }}
terraform_kayobe_multinode_version: ${{ steps.generate-inputs.outputs.terraform_kayobe_multinode_version }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -45,6 +46,7 @@ jobs:
upgrade: ${{ needs.generate-inputs.outputs.upgrade }}
stackhpc_kayobe_config_version: ${{ needs.generate-inputs.outputs.stackhpc_kayobe_config_version }}
stackhpc_kayobe_config_previous_version: ${{ needs.generate-inputs.outputs.stackhpc_kayobe_config_previous_version }}
terraform_kayobe_multinode_version: ${{ needs.generate-inputs.outputs.terraform_kayobe_multinode_version }}
enable_slack_alert: true
secrets: inherit
if: github.repository == 'stackhpc/stackhpc-kayobe-config'
Loading