-
Notifications
You must be signed in to change notification settings - Fork 8
fix(ui): resolved back button alignment #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(ui): resolved back button alignment #1108
Conversation
Signed-off-by: Michele Mazzucco <[email protected]>
Signed-off-by: Michele Mazzucco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the back button alignment issue (#510) by adjusting the button styling and layout. The changes switch from a ghost button variant to a link variant and modify padding/spacing to improve visual alignment.
Key Changes
- Changed back button from
variant="ghost"tovariant="link"for better visual styling - Reduced ChevronLeft icon size from
size-5tosize-4for better proportion - Added compound variant styling to remove default padding from link buttons
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| renderer/src/routes/(registry)/registry_.$name.tsx | Updated back button variant and icon size, wrapped in container div with vertical margin |
| renderer/src/common/components/ui/button.tsx | Added cursor-pointer class and compound variants for link button styling |
|
Thank you, @michelemazzucco ❤️ looks great! Just one thing: we were thinking of going back to a regular button like this:
What do you think? |
I considered that option too, but I didn't commit to it because of the impact on the overall page hierarchy – i.e. it would give the back button more visibility/relevance than the one it might actually require. But if you're happy with that approach, I can update it to use that variant instead 👀 |
I need to validate this internally, I’ll circle back to you tomorrow |
|
@michelemazzucco let's go with your proposal, can you apply this to all the back button you find? |


Description
PR to fix this issue: #510
Additional Changes
I also added the
cursor-pointerclass to the button. While this is the default cursor for buttons in browsers, Electron appears to use thedefaultcursor instead.Screenshots
Extra / Suggestions
I tried to follow what was suggested in the issue, but there are two extra tweaks that I think would be nice to add:
A. Color instead of underline
Instead of using an underline, I would use a color change instead. This works better when there's an icon contained in the button.
B. ChevronLeft vs ArrowLeftIcon
As you can see from the screenshots below, the
ChevronLefticon, due to its frame offset, contributes to creating a misalignment effect. TheArrowLeftIconmight help reduce this misalignment effect.Please let me know what you think :)