Skip to content

Conversation

@michelemazzucco
Copy link

@michelemazzucco michelemazzucco commented Oct 20, 2025

Description

PR to fix this issue: #510

Additional Changes

I also added the cursor-pointer class to the button. While this is the default cursor for buttons in browsers, Electron appears to use the default cursor instead.

Screenshots

CleanShot 2025-10-20 at 21 08 31@2x

Extra / Suggestions

I tried to follow what was suggested in the issue, but there are two extra tweaks that I think would be nice to add:

A. Color instead of underline

Instead of using an underline, I would use a color change instead. This works better when there's an icon contained in the button.

CleanShot 2025-10-20 at 21 11 50

B. ChevronLeft vs ArrowLeftIcon

As you can see from the screenshots below, the ChevronLeft icon, due to its frame offset, contributes to creating a misalignment effect. The ArrowLeftIcon might help reduce this misalignment effect.

CleanShot 2025-10-20 at 21 20 04@2x

Please let me know what you think :)

@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 19:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the back button alignment issue (#510) by adjusting the button styling and layout. The changes switch from a ghost button variant to a link variant and modify padding/spacing to improve visual alignment.

Key Changes

  • Changed back button from variant="ghost" to variant="link" for better visual styling
  • Reduced ChevronLeft icon size from size-5 to size-4 for better proportion
  • Added compound variant styling to remove default padding from link buttons

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
renderer/src/routes/(registry)/registry_.$name.tsx Updated back button variant and icon size, wrapped in container div with vertical margin
renderer/src/common/components/ui/button.tsx Added cursor-pointer class and compound variants for link button styling

@samuv
Copy link
Collaborator

samuv commented Oct 21, 2025

Thank you, @michelemazzucco ❤️ looks great!

Just one thing: we were thinking of going back to a regular button like this:

Registry Server Description

What do you think?

@samuv samuv self-assigned this Oct 21, 2025
@michelemazzucco
Copy link
Author

Thank you, @michelemazzucco ❤️ looks great!

Just one thing: we were thinking of going back to a regular button like this:

Registry Server Description What do you think?

I considered that option too, but I didn't commit to it because of the impact on the overall page hierarchy – i.e. it would give the back button more visibility/relevance than the one it might actually require.

But if you're happy with that approach, I can update it to use that variant instead 👀

@samuv
Copy link
Collaborator

samuv commented Oct 21, 2025

Thank you, @michelemazzucco ❤️ looks great!
Just one thing: we were thinking of going back to a regular button like this:
What do you think?

I considered that option too, but I didn't commit to it because of the impact on the overall page hierarchy – i.e. it would give the back button more visibility/relevance than the one it might actually require.

But if you're happy with that approach, I can update it to use that variant instead 👀

I need to validate this internally, I’ll circle back to you tomorrow

@samuv
Copy link
Collaborator

samuv commented Oct 24, 2025

@michelemazzucco let's go with your proposal, can you apply this to all the back button you find?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants