Skip to content

fix(ui): resolved back button alignment #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui): resolved back button alignment #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c60fb
fix(ui): removed paddings from link variant, added cursor pointer
michelemazzucco Oct 20, 2025
9ebcff7
style: added margins to match prev spacing
michelemazzucco Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion renderer/src/common/components/ui/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { cva, type VariantProps } from 'class-variance-authority'
import { cn } from '@/common/lib/utils'

const buttonVariants = cva(
"inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md text-sm font-medium transition-all disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg:not([class*='size-'])]:size-4 shrink-0 [&_svg]:shrink-0 outline-none focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:ring-[3px] aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive",
"cursor-pointer inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-md text-sm font-medium transition-all disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg:not([class*='size-'])]:size-4 shrink-0 [&_svg]:shrink-0 outline-none focus-visible:border-ring focus-visible:ring-ring/50 focus-visible:ring-[3px] aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive",
{
variants: {
variant: {
Expand All @@ -31,6 +31,13 @@ const buttonVariants = cva(
icon: 'size-9',
},
},
compoundVariants: [
{
variant: 'link',
size: ['default', 'xs', 'sm', 'lg', 'icon'],
className: 'p-0 h-auto has-[>svg]:px-0',
},
],
defaultVariants: {
variant: 'default',
size: 'default',
Expand Down
22 changes: 12 additions & 10 deletions renderer/src/routes/(registry)/registry_.$name.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,18 @@ export function RegistryServerDetail() {

return (
<div className="flex max-h-full w-full flex-1 flex-col">
<LinkViewTransition to="/registry">
<Button
variant="ghost"
aria-label="Back"
className="text-muted-foreground"
>
<ChevronLeft className="size-5" />
Back
</Button>
</LinkViewTransition>
<div className="my-2">
<LinkViewTransition to="/registry">
<Button
variant="link"
aria-label="Back"
className="text-muted-foreground"
>
<ChevronLeft className="size-4" />
Back
</Button>
</LinkViewTransition>
</div>

<div className="flex flex-col gap-3">
<h1 className="m-0 mb-0 p-0 text-3xl font-bold">{name}</h1>
Expand Down
Loading