-
Notifications
You must be signed in to change notification settings - Fork 165
ROX-29057: Update ESLint 9.25.1 #15079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pedrottimark - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider running
npm audit fixto address any potential security vulnerabilities in the updated dependencies. - The PR description is very detailed and helpful, thank you.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 2e86593. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15079 +/- ##
==========================================
- Coverage 48.99% 48.99% -0.01%
==========================================
Files 2550 2550
Lines 187230 187230
==========================================
- Hits 91731 91729 -2
- Misses 88249 88250 +1
- Partials 7250 7251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
ESLint releases a minor update every other Friday.
Update about once a month seems like a healthy return on investment:
Procedure
Remember to update some packages in
overridesif needed.npm installto update package-lock.json file according to changes in package.json file.npm cito delete and recreate ui/apps/platform/node_modules folder.eslint
https://eslint.org/blog/2025/04/eslint-v9.25.0-released/
Although
@typescript-eslintconfigs turn off some ESLint rules that now have TypeScript syntax support, so far there is low return on investment to fight it.eslint-plugin-cypress
cypress-io/eslint-plugin-cypress#249
prettier
https://prettier.io/blog/2025/02/09/3.5.0
https://prettier.io/blog/2025/02/09/3.5.0#improve-word-wrapping-edge-cases-in-jsx-16700-by-seiyab
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run lintin ui/apps/platformnpm run buildin ui/apps/platform