Skip to content

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Apr 24, 2025

Description

ESLint releases a minor update every other Friday.

Update about once a month seems like a healthy return on investment:

  • 10% of outdated dependencies
  • 4 errors in 2 files

Procedure

Remember to update some packages in overrides if needed.

  • For contribution: npm install to update package-lock.json file according to changes in package.json file.
  • For team: npm ci to delete and recreate ui/apps/platform/node_modules folder.

eslint

https://eslint.org/blog/2025/04/eslint-v9.25.0-released/

As announced in the ESLint v9.23.0 release blog post, we are actively working to add TypeScript syntax support to core rules.

Although @typescript-eslint configs turn off some ESLint rules that now have TypeScript syntax support, so far there is low return on investment to fight it.

eslint-plugin-cypress

cypress-io/eslint-plugin-cypress#249

This rule disallows the usage of chained .get() calls as cy.get() always starts its search from the cy.root element.

prettier

https://prettier.io/blog/2025/02/09/3.5.0

https://prettier.io/blog/2025/02/09/3.5.0#improve-word-wrapping-edge-cases-in-jsx-16700-by-seiyab

User-facing documentation

  • CHANGELOG update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • enabled lint rule
  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run lint in ui/apps/platform
  2. npm run build in ui/apps/platform

@pedrottimark pedrottimark requested a review from a team as a code owner April 24, 2025 18:59
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pedrottimark - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider running npm audit fix to address any potential security vulnerabilities in the updated dependencies.
  • The PR description is very detailed and helpful, thank you.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pedrottimark pedrottimark changed the title Rox 29057 eslint 9.25.1 dev dependencies ROX-29057: Update ESLint 9.25.1 Apr 24, 2025
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 2e86593.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-545-g2e8659396c.

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (a18ef47) to head (2e86593).
Report is 36 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15079      +/-   ##
==========================================
- Coverage   48.99%   48.99%   -0.01%     
==========================================
  Files        2550     2550              
  Lines      187230   187230              
==========================================
- Hits        91731    91729       -2     
- Misses      88249    88250       +1     
- Partials     7250     7251       +1     
Flag Coverage Δ
go-unit-tests 48.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pedrottimark pedrottimark merged commit 8e77262 into master Apr 29, 2025
86 of 87 checks passed
@pedrottimark pedrottimark deleted the ROX-29057-eslint-9.25.1-devDependencies branch April 29, 2025 14:16
vikin91 pushed a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants