Skip to content

ROX-29057: Update ESLint 9.25.1 #15079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

ROX-29057: Update ESLint 9.25.1 #15079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f5906f
ROX-29057: Update ESLint 9.25.1
Apr 24, 2025
e3fbd20
Update prettier and fix 2 errors in SignatureIntegrationForm.tsx file
Apr 24, 2025
2e86593
Enable cypress/no-chained-get lint rule and fix 2 errors in violation…
Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions ui/apps/platform/cypress/integration/violations/violations.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,27 +99,22 @@ describe('Violations', () => {
it('should contain correct action buttons for the lifecycle stage', () => {
visitViolationsWithFixture('alerts/alerts.json');

const { actions } = selectors;
const { btn, excludeDeploymentBtn, resolveAndAddToBaselineBtn, resolveBtn } = actions;

// Lifecycle: Runtime
cy.get(`tbody tr:nth-child(1) ${selectors.actions.btn}`).click(); // click kabob to open actions menu
cy.get('tbody tr:nth-child(1)')
.get(selectors.actions.excludeDeploymentBtn)
.should('exist')
.get(selectors.actions.resolveBtn)
.should('exist')
.get(selectors.actions.resolveAndAddToBaselineBtn)
.should('exist');
cy.get(`tbody tr:nth-child(1) ${selectors.actions.btn}`).click(); // click kabob to close actions menu
cy.get(`tbody tr:nth-child(1) ${btn}`).click(); // click kabob to open actions menu
cy.get(`tbody tr:nth-child(1) ${excludeDeploymentBtn}`).should('exist');
cy.get(`tbody tr:nth-child(1) ${resolveBtn}`).should('exist');
cy.get(`tbody tr:nth-child(1) ${resolveAndAddToBaselineBtn}`).should('exist');
cy.get(`tbody tr:nth-child(1) ${btn}`).click(); // click kabob to close actions menu

// Lifecycle: Deploy
cy.get(`tbody tr:nth-child(3) ${selectors.actions.btn}`).click(); // click kabob to open actions menu
cy.get('tbody tr:nth-child(3)')
.get(selectors.actions.resolveBtn)
.should('not.exist')
.get(selectors.actions.resolveAndAddToBaselineBtn)
.should('not.exist')
.get(selectors.actions.excludeDeploymentBtn)
.should('exist');
cy.get(`tbody tr:nth-child(3) ${selectors.actions.btn}`).click(); // click kabob to close actions menu
cy.get(`tbody tr:nth-child(3) ${btn}`).click(); // click kabob to open actions menu
cy.get(`tbody tr:nth-child(3) ${resolveBtn}`).should('not.exist');
cy.get(`tbody tr:nth-child(3) ${resolveAndAddToBaselineBtn}`).should('not.exist');
cy.get(`tbody tr:nth-child(3) ${excludeDeploymentBtn}`).should('exist');
cy.get(`tbody tr:nth-child(3) ${btn}`).click(); // click kabob to close actions menu
});

// TODO test of bulk actions
Expand Down
1 change: 1 addition & 0 deletions ui/apps/platform/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ module.exports = [
// Turn off new rules until after we fix errors in follow-up contributions.
'cypress/no-unnecessary-waiting': 'off', // disable or fix about 8 errors

'cypress/no-chained-get': 'error',
// 'cypress/no-force': 'error', // TODO fix errors

'jest/no-focused-tests': 'error',
Expand Down
Loading
Loading