chore: disable all unused dependencies' default-features #6367

Jiloc · 2025-08-11T15:27:01Z

Description

centralized all dependencies ~~common to 2+ crates~~ into the workspace's Cargo.toml.
- Originally planned for only common dependencies, but moving all ensures a single source of truth and avoids mistakes when adding new crates (e.g., missing that a dependency already exists elsewhere).
Updated workspace crates to use workspace = true.
Set default-features = false for all crates, enabling only explicitly required features.
Unified dependency versions across crates; upgraded chrono in stacks-node to match stacks-common (0.4.19 → 0.4.41).
Removed unused crates (cargo machete --with-metadata) and added exceptions for required ones, e.g.:

[package.metadata.cargo-machete]
ignored = ["stdext"]

Applied cargo sort -g -w to format all Cargo.toml files.
Moved to resolver = "3"

Applicable issues

fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

Test coverage for new or modified code paths
Changelog is updated
Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
New clarity functions have corresponding PR in clarity-benchmarking repo
New integration test(s) added to bitcoin-tests.yml

This reverts commit 915fcf5.

Jiloc · 2025-08-12T15:42:11Z

clarity-serialization/Cargo.toml

-mutants = "0.0.3"
-rstest = "0.17.0"
+[package.metadata.cargo-machete]
+ignored = ["slog"]


slog is needed when we use the various info!, debug!, etc. macros. cargo machete is not so good with macros though and marks it as unused (same story for all others [package.metadata.cargo-machete] in the various files)

Jiloc · 2025-08-12T15:47:13Z

contrib/tools/config-docs-generator/Cargo.toml

the dependencies on this file were not changed because #6371 will move this crate out of the workspace

Jiloc · 2025-08-12T15:49:20Z

stacks-node/Cargo.toml

+# This dependency is used for the multiversion integration tests which live behind the build-v3-1-0-0-13 feature flag
+libsigner_v3_1_0_0_13 = { package = "libsigner", git = "https://github.com/stacks-network/stacks-core.git", rev = "8a79aaa7df0f13dfc5ab0d0d0bcb8201c90bcba2", optional = true }
+signer_v3_1_0_0_13 = { package = "stacks-signer", git = "https://github.com/stacks-network/stacks-core.git", rev = "8a79aaa7df0f13dfc5ab0d0d0bcb8201c90bcba2", optional = true, features = ["testing", "default"] }
+stacks_common_v3_1_00_13 = { package = "stacks-common", git = "https://github.com/stacks-network/stacks-core.git", rev = "8a79aaa7df0f13dfc5ab0d0d0bcb8201c90bcba2", optional = true, features = ["testing", "default"] }
+stacks_v3_1_00_13 = { package = "stackslib", git = "https://github.com/stacks-network/stacks-core.git", rev = "8a79aaa7df0f13dfc5ab0d0d0bcb8201c90bcba2", optional = true, features = ["testing", "default"] }


I left these here because I am not sure if these will be removed in the future and were a temporary test?

This is a question for @jferrant I think.

Jiloc · 2025-08-12T15:52:28Z

stackslib/src/net/mod.rs

the changes in this file were needed because mio::tcp:: was a deprecated module, internally exposing mio::net::. The "forwarding" of the module was feature gated behind #[cfg(feature = "with-deprecated")] (included by default)

Heh, we just need to rip out mio altogether at some point (#3886).

This change is fine, btw.

cylewitruk · 2025-08-13T15:09:09Z

clarity/Cargo.toml

 readme = "README.md"
 edition = "2021"
-resolver = "2"
+resolver = "3"


Here and elsewhere, resolver only needs to be specified in the workspace root

fdefelici · 2025-08-14T08:19:01Z

clarity/Cargo.toml

@@ -56,3 +38,29 @@ devtools = []
 rollback_value_check = []
 disable-costs = []
 wasm-web = ["stacks_common/wasm-web"]
+
+[dependencies]
+hashbrown.workspace = true


Since we’re reviewing the overall workspace approach, I’ll mention a small style point here.
Functionally <dependency>.workspace = true is fine and my comment is purely about consistency.

Could we consider always using the <dependency> = { workspace = true } form?
Even though it’s slightly more verbose, this keeps the format uniform across the workspace, makes the dependency name stand out more clearly, and simplifies future edits if we need to add more fields.

fdefelici · 2025-08-14T10:16:24Z

Cargo.toml

+libsigner = { path = "./libsigner", default-features = false }
+libstackerdb = { path = "./libstackerdb", default-features = false }
+pox-locking = { path = "./pox-locking", default-features = false }
+stacks = { package = "stackslib", path = "./stackslib", default-features = false }  # Alias for stackslib


Not for this PR, but I’m wondering if we could remove the stacks alias and just use stackslib directly.

This would require updating use statements across the codebase from use stacks::... to use stackslib::... but it shouldn’t be a critical change.

The main benefit would be improved clarity and consistency.

remove all unused features

3853b10

Jiloc self-assigned this Aug 11, 2025

Jiloc added 3 commits August 11, 2025 16:34

add serde_json/std to wasm-web

8e5085a

fix cargo hack check

4aa3c14

fix cargo clippy-stacks

8e97501

Jiloc added this to the 3.2.0.0.1 milestone Aug 11, 2025

Jiloc added this to Stacks Core Eng Aug 11, 2025

remove unused crates

d64adcc

Jiloc moved this to Status: 💻 In Progress in Stacks Core Eng Aug 11, 2025

Jiloc added 6 commits August 12, 2025 10:39

split test crates. move dep-only deps

f4e095f

remove config-docs-generator from workspace

915fcf5

Revert "remove config-docs-generator from workspace"

4037c6f

This reverts commit 915fcf5.

move all deps to workspace. format cargo files

6980253

remove unused crates with cargo machete

49f0266

cargo fmt

43bda47

Jiloc commented Aug 12, 2025

View reviewed changes

Jiloc added 2 commits August 12, 2025 16:45

revert config-docs-generator/Cargo.toml

ab327d5

cargo sort -g -w

983b756

Jiloc commented Aug 12, 2025

View reviewed changes

Jiloc moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Aug 12, 2025

Jiloc marked this pull request as ready for review August 12, 2025 16:09

Jiloc requested review from a team as code owners August 12, 2025 16:09

aldur requested review from fdefelici and cylewitruk August 13, 2025 15:01

cylewitruk reviewed Aug 13, 2025

View reviewed changes

fdefelici reviewed Aug 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: disable all unused dependencies' default-features #6367

chore: disable all unused dependencies' default-features #6367

Uh oh!

Jiloc commented Aug 11, 2025 •

edited

Loading

Uh oh!

Jiloc Aug 12, 2025

Uh oh!

Jiloc Aug 12, 2025

Uh oh!

Jiloc Aug 12, 2025

Uh oh!

jcnelson Aug 13, 2025

Uh oh!

Jiloc Aug 12, 2025

Uh oh!

jcnelson Aug 13, 2025

Uh oh!

jcnelson Aug 13, 2025

Uh oh!

cylewitruk Aug 13, 2025

Uh oh!

fdefelici Aug 14, 2025

Uh oh!

fdefelici Aug 14, 2025

Uh oh!

Uh oh!

chore: disable all unused dependencies' default-features #6367

Are you sure you want to change the base?

chore: disable all unused dependencies' default-features #6367

Uh oh!

Conversation

Jiloc commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jiloc commented Aug 11, 2025 •

edited

Loading