Skip to content

chore: disable all unused dependencies' default-features #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
+497 −488
Open

chore: disable all unused dependencies' default-features #6367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3853b10
remove all unused features
Jiloc Aug 11, 2025
8e5085a
add serde_json/std to wasm-web
Jiloc Aug 11, 2025
4aa3c14
fix cargo hack check
Jiloc Aug 11, 2025
8e97501
fix cargo clippy-stacks
Jiloc Aug 11, 2025
d64adcc
remove unused crates
Jiloc Aug 11, 2025
f4e095f
split test crates. move dep-only deps
Jiloc Aug 12, 2025
915fcf5
remove config-docs-generator from workspace
Jiloc Aug 12, 2025
4037c6f
Revert "remove config-docs-generator from workspace"
Jiloc Aug 12, 2025
6980253
move all deps to workspace. format cargo files
Jiloc Aug 12, 2025
49f0266
remove unused crates with cargo machete
Jiloc Aug 12, 2025
43bda47
cargo fmt
Jiloc Aug 12, 2025
ab327d5
revert config-docs-generator/Cargo.toml
Jiloc Aug 12, 2025
983b756
cargo sort -g -w
Jiloc Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 2 additions & 103 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

110 changes: 88 additions & 22 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,100 @@
[workspace]
resolver = "2"
resolver = "3"
members = [
"stackslib",
"stacks-common",
"pox-locking",
"clarity-serialization",
"clarity",
"stx-genesis",
"libstackerdb",
"clarity-serialization",
"contrib/tools/config-docs-generator",
"libsigner",
"stacks-signer",
"libstackerdb",
"pox-locking",
"stacks-common",
"stacks-node",
"contrib/tools/config-docs-generator"]
"stacks-signer",
"stackslib",
"stx-genesis",
]

# Dependencies we want to keep the same between workspace members
[workspace.dependencies]
# Local Crates
clarity = { path = "./clarity", default-features = false }
clarity-serialization = { path = "./clarity-serialization", default-features = false }
libsigner = { path = "./libsigner", default-features = false }
libstackerdb = { path = "./libstackerdb", default-features = false }
pox-locking = { path = "./pox-locking", default-features = false }
stacks = { package = "stackslib", path = "./stackslib", default-features = false } # Alias for stackslib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I’m wondering if we could remove the stacks alias and just use stackslib directly.

This would require updating use statements across the codebase from use stacks::... to use stackslib::... but it shouldn’t be a critical change.

The main benefit would be improved clarity and consistency.

stacks-common = { path = "./stacks-common", default-features = false }
stacks-signer = { path = "./stacks-signer", default-features = false }
stackslib = { path = "./stackslib", default-features = false }
stx-genesis = { path = "./stx-genesis", default-features = false }

# Stacks' dependencies
madhouse = { git = "https://github.com/stacks-network/madhouse-rs.git", default-features = false, tag = "0.2.0" }
pinny = { git = "https://github.com/BitcoinL2-Labs/pinny-rs.git", default-features = false, rev = "54ba9d533a7b84525a5e65a3eae1a3ae76b9ea49" } #v0.0.2

# Crates.io
async-h1 = { version = "2.3.2", default-features = false }
async-std = { version = "1.6", features = ["attributes"] } # requires default features
backoff = { version = "0.4", default-features = false }
backtrace = { version = "0.3.50", default-features = false, features = ["std"] }
base64 = { version = "0.12.0", default-features = false, features = ["std"] }
chrono = { version = "0.4.41", default-features = false }
clap = { version = "4.1.1", features = ["derive", "env"] }
curve25519-dalek = { version = "4.1.3", default-features = false, features = ["serde"] }
ed25519-dalek = { version = "2.1.1", default-features = false }
getrandom = { version = "0.2", default-features = false }
hashbrown = { version = "0.15.2", features = ["serde"] }
lazy_static = "1.4.0"
rand_core = "0.6.4"
rand = "0.8"
rand_chacha = "0.3.1"
serde = "1"
serde_derive = "1"
serde_json = { version = "1.0", features = ["arbitrary_precision", "unbounded_depth"] }
slog = { version = "2.5.2", features = [ "max_level_trace" ] }
rusqlite = { version = "0.31.0", features = ["blob", "serde_json", "i128_blob", "bundled", "trace"] }
tikv-jemallocator = "0.5.4"
thiserror = "1.0.65"
toml = "0.5.6"
http-types = { version = "2.12", default-features = false }
integer-sqrt = { version = "0.1.3", default-features = false }
lazy_static = { version = "1.4.0", default-features = false }
libc = { version = "0.2.151", default-features = false }
libflate = { version = "1.0.3", default-features = false }
libsecp256k1 = { version = "0.7.0", default-features = false, features = ["hmac"] }
mio = { version = "0.6", default-features = false }
nix = { version = "0.23", default-features = false }
percent-encoding = { version = "2.1.0", default-features = false }
pico-args = { version = "0.5.0", default-features = false }
prometheus = { version = "0.9", default-features = false }
rand = { version = "0.8", default-features = false }
rand_chacha = { version = "0.3.1", default-features = false }
regex = { version = "1", default-features = false }
reqwest = { version = "0.11.22", default-features = false, features = ["blocking", "json", "rustls-tls"] }
ripemd = { version = "0.1.1", default-features = false }
rusqlite = { version = "0.31.0", default-features = false, features = ["blob", "serde_json", "i128_blob", "bundled", "trace"] }
secp256k1 = { version = "0.24.3", default-features = false, features = ["std","serde", "recovery"] }
serde = { version = "1", default-features = false }
serde_derive = { version = "1", default-features = false }
serde_json = { version = "1.0", default-features = false }
serde_stacker = { version = "0.1", default-features = false }
sha2 = { version = "0.10", default-features = false, features = ["std"] }
sha3 = { version = "0.10.1", default-features = false }
siphasher = { version = "0.3.7", default-features = false }
slog = { version = "2.5.2", default-features = false, features = [ "max_level_trace" ] }
slog-json = { version = "2.3.0", default-features = false }
slog-term = { version = "2.6.0", default-features = false }
thiserror = { version = "1.0.65", default-features = false }
tikv-jemallocator = { version = "0.5.4", default-features = false }
time = { version = "0.3.41", default-features = false }
tiny_http = { version = "0.12.0", default-features = false }
toml = { version = "0.5.6", default-features = false }
tracing = { version = "0.1.37", default-features = false }
tracing-subscriber = { version = "0.3.17", default-features = false, features = ["env-filter"] }
url = { version = "2.1.0", default-features = false }
winapi = { version = "0.3", default-features = false }

# Tests-only
assert-json-diff = { version = "1.0.0", default-features = false }
mockito = { version = "1.5", default-features = false }
mutants = { version = "0.0.3", default-features = false }
proptest = { version = "1.6.*", default-features = false, features = ["std"] }
rand_core = { version = "0.6.4", default-features = false }
rlimit = { version = "0.10.2", default-features = false }
rstest = { version = "0.17.0", default-features = false }
rstest_reuse = { version = "0.5.0", default-features = false }
serial_test = { version = "3.2.0", default-features = false }
stdext = { version = "0.3.1", default-features = false }
tempfile = { version = "3.3", default-features = false }
tokio = { version = "1.15", default-features = false }
warp = { version = "0.3.5", default-features = false }

# Use a bit more than default optimization for
# dev builds to speed up test execution
Expand Down
Loading
Loading