Skip to content

Conversation

Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Aug 12, 2025

Description

Stop building config-docs-generator when running cargo build.

The crate is still being built and used in CI: https://github.com/stacks-network/stacks-core/actions/runs/16906844825/job/47899670930?pr=6371

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc self-assigned this Aug 12, 2025
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Aug 12, 2025
@Jiloc Jiloc added this to the 3.2.0.0.1 milestone Aug 12, 2025
@Jiloc Jiloc marked this pull request as ready for review August 12, 2025 15:34
@Jiloc Jiloc requested review from a team as code owners August 12, 2025 15:34
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Aug 14, 2025
@Jiloc Jiloc added this pull request to the merge queue Aug 14, 2025
@Jiloc Jiloc moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Aug 14, 2025
Merged via the queue into stacks-network:develop with commit ce2ab4f Aug 14, 2025
3 of 4 checks passed
@Jiloc Jiloc deleted the chore/exclude-config-docs-generator-from-workspace branch August 14, 2025 16:58
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.95%. Comparing base (a9e2828) to head (99642fd).
⚠️ Report is 78 commits behind head on develop.

❌ Your project status has failed because the head coverage (75.95%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6371       +/-   ##
============================================
+ Coverage    62.44%   75.95%   +13.51%     
============================================
  Files          552      549        -3     
  Lines       351797   348635     -3162     
============================================
+ Hits        219676   264816    +45140     
+ Misses      132121    83819    -48302     

see 403 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e2828...99642fd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants