Skip to content

feat: allow epoch 3.3.0 in node config #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: allow epoch 3.3.0 in node config #6584

wants to merge 1 commit into from

Conversation

hugoclrd
Copy link
Contributor

@hugoclrd hugoclrd commented Oct 9, 2025

Description

Allow setting the epoch 3.3 height in config, but don't make it mandatory

[[burnchain.epochs]]
epoch_name = "3.3"
start_height = 147

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@hugoclrd hugoclrd marked this pull request as ready for review October 9, 2025 18:01
@hugoclrd hugoclrd requested review from a team as code owners October 9, 2025 18:01
brice-stacks
brice-stacks reviewed Oct 9, 2025
View reviewed changes
stackslib/src/config/mod.rs
StacksEpochId::Epoch30,
StacksEpochId::Epoch31,
StacksEpochId::Epoch32,
// todo: when epoch 3.3 becomes mandatory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue for that TODO and tag it with 3.3.0.0.0 so we don't forget it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created here: #6588

But I'm not allowed to set tags

obycode
obycode approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugoclrd hugoclrd mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obycode obycode obycode approved these changes

+1 more reviewer

@brice-stacks brice-stacks brice-stacks left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugoclrd @obycode @brice-stacks